Hide fullscreen rotation jank

chrome/browser/android/compositor/compositor_view.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/compositor/compositor_view.h"
 
 #include <android/bitmap.h>
 #include <android/native_window_jni.h>
 
 #include <memory>
@@ skipping 11 matching lines @@
 #include "cc/layers/solid_color_layer.h"
 #include "cc/layers/texture_layer.h"
 #include "chrome/browser/android/compositor/layer/toolbar_layer.h"
 #include "chrome/browser/android/compositor/layer_title_cache.h"
 #include "chrome/browser/android/compositor/scene_layer/scene_layer.h"
 #include "chrome/browser/android/compositor/tab_content_manager.h"
 #include "content/public/browser/android/compositor.h"
 #include "content/public/browser/android/content_view_core.h"
 #include "content/public/browser/child_process_data.h"
 #include "content/public/browser/web_contents.h"
+#include "content/public/common/content_features.h"
 #include "content/public/common/process_type.h"
 #include "jni/CompositorView_jni.h"
 #include "third_party/skia/include/core/SkBitmap.h"
 #include "ui/android/resources/resource_manager.h"
 #include "ui/android/resources/ui_resource_provider.h"
 #include "ui/android/window_android.h"
 #include "ui/gfx/android/java_bitmap.h"
 
 using base::android::JavaParamRef;
 
@@ skipping 136 matching lines @@
   gfx::Size size(width, height);
   web_contents->GetNativeView()->OnPhysicalBackingSizeChanged(size);
 }
 
 void CompositorView::SetLayoutBounds(JNIEnv* env,
                                      const JavaParamRef<jobject>& object) {
   root_layer_->SetBounds(gfx::Size(content_width_, content_height_));
 }
 
 void CompositorView::SetBackground(bool visible, SkColor color) {
-  if (overlay_video_mode_)
+  // TODO(steimel): Remove this feature flag and the hack inside this if block
+  // once we're confident that the fullscreen transition hiding is working
+  // properly.
+  if (!base::FeatureList::IsEnabled(features::kHideFullscreenTransitionJank) &&
+      overlay_video_mode_) {
     visible = false;
+  }
   root_layer_->SetBackgroundColor(color);
   root_layer_->SetIsDrawable(visible);
+  // TODO(steimel): Remove this feature flag check once we're confident that the
+  // fullscreen transition hiding is working properly.
+  if (base::FeatureList::IsEnabled(features::kHideFullscreenTransitionJank)) {
+    compositor_->SetBackgroundColor(color);
+    compositor_->SetHasTransparentBackground(SkColorGetA(color) ==
+                                             SK_AlphaTRANSPARENT);
+  }
 }
 
 void CompositorView::SetOverlayVideoMode(JNIEnv* env,
                                          const JavaParamRef<jobject>& object,
                                          bool enabled) {
   if (overlay_video_mode_ == enabled)
     return;
   overlay_video_mode_ = enabled;
-  compositor_->SetHasTransparentBackground(enabled);
+  // TODO(steimel): Remove this feature flag and the hack inside this if block
+  // once we're confident that the fullscreen transition hiding is working
+  // properly.
+  if (!base::FeatureList::IsEnabled(features::kHideFullscreenTransitionJank)) {
+    compositor_->SetHasTransparentBackground(enabled);
+  }
   SetNeedsComposite(env, object);
 }
 
 void CompositorView::SetSceneLayer(JNIEnv* env,
                                    const JavaParamRef<jobject>& object,
                                    const JavaParamRef<jobject>& jscene_layer) {
   SceneLayer* scene_layer = SceneLayer::FromJavaObject(env, jscene_layer);
 
   if (scene_layer_ != scene_layer) {
     // The old tree should be detached only if it is not the cached layer or
@@ skipping 59 matching lines @@
   // The Android TERMINATION_STATUS_OOM_PROTECTED hack causes us to never go
   // through here but through BrowserChildProcessHostDisconnected() instead.
 }
 
 // Register native methods
 bool RegisterCompositorView(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android