Hide fullscreen rotation jank

chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/android/compositor/scene_layer/tab_list_scene_layer.h"
 
 #include "base/android/jni_android.h"
 #include "chrome/browser/android/compositor/layer/content_layer.h"
 #include "chrome/browser/android/compositor/layer/tab_layer.h"
 #include "chrome/browser/android/compositor/layer_title_cache.h"
@@ skipping 68 matching lines @@
   if (!tab_content_manager_) {
     tab_content_manager_ =
         TabContentManager::FromJavaObject(jtab_content_manager);
   }
 
   background_color_ = background_color;
   own_tree_->SetPosition(gfx::PointF(viewport_x, viewport_y));
   own_tree_->SetBounds(gfx::Size(viewport_width, viewport_height));
 }
 
-void TabListSceneLayer::PutTabLayer(
-    JNIEnv* env,
-    const JavaParamRef<jobject>& jobj,
-    jint id,
-    jint toolbar_resource_id,
-    jint close_button_resource_id,
-    jint shadow_resource_id,
-    jint contour_resource_id,
-    jint back_logo_resource_id,
-    jint border_resource_id,
-    jint border_inner_shadow_resource_id,
-    jboolean can_use_live_layer,
-    jboolean browser_controls_at_bottom,
-    jint tab_background_color,
-    jint back_logo_color,
-    jboolean incognito,
-    jboolean is_portrait,
-    jfloat x,
-    jfloat y,
-    jfloat width,
-    jfloat height,
-    jfloat content_width,
-    jfloat content_height,
-    jfloat visible_content_height,
-    jfloat shadow_x,
-    jfloat shadow_y,
-    jfloat shadow_width,
-    jfloat shadow_height,
-    jfloat pivot_x,
-    jfloat pivot_y,
-    jfloat rotation_x,
-    jfloat rotation_y,
-    jfloat alpha,
-    jfloat border_alpha,
-    jfloat border_inner_shadow_alpha,
-    jfloat contour_alpha,
-    jfloat shadow_alpha,
-    jfloat close_alpha,
-    jfloat close_btn_width,
-    jfloat static_to_view_blend,
-    jfloat border_scale,
-    jfloat saturation,
-    jfloat brightness,
-    jboolean show_toolbar,
-    jint default_theme_color,
-    jint toolbar_background_color,
-    jint close_button_color,
-    jboolean anonymize_toolbar,
-    jboolean show_tab_title,
-    jint toolbar_textbox_resource_id,
-    jint toolbar_textbox_background_color,
-    jfloat toolbar_textbox_alpha,
-    jfloat toolbar_alpha,
-    jfloat toolbar_y_offset,
-    jfloat side_border_scale,
-    jboolean inset_border) {
+void TabListSceneLayer::PutTabLayer(JNIEnv* env,
+                                    const JavaParamRef<jobject>& jobj,

[aelias_OOO_until_Jul13, 2017/06/22 02:52:05]

Now that you no longer need to touch these files, please remove the "git cl
format" changes from the patch to unclutter the code review and git blame
history.

[steimel, 2017/06/29 00:38:51]

Done.

+                                    jint id,
+                                    jint toolbar_resource_id,
+                                    jint close_button_resource_id,
+                                    jint shadow_resource_id,
+                                    jint contour_resource_id,
+                                    jint back_logo_resource_id,
+                                    jint border_resource_id,
+                                    jint border_inner_shadow_resource_id,
+                                    jboolean can_use_live_layer,
+                                    jboolean browser_controls_at_bottom,
+                                    jint tab_background_color,
+                                    jint back_logo_color,
+                                    jboolean incognito,
+                                    jboolean is_portrait,
+                                    jfloat x,
+                                    jfloat y,
+                                    jfloat width,
+                                    jfloat height,
+                                    jfloat content_width,
+                                    jfloat content_height,
+                                    jfloat visible_content_height,
+                                    jfloat shadow_x,
+                                    jfloat shadow_y,
+                                    jfloat shadow_width,
+                                    jfloat shadow_height,
+                                    jfloat pivot_x,
+                                    jfloat pivot_y,
+                                    jfloat rotation_x,
+                                    jfloat rotation_y,
+                                    jfloat alpha,
+                                    jfloat border_alpha,
+                                    jfloat border_inner_shadow_alpha,
+                                    jfloat contour_alpha,
+                                    jfloat shadow_alpha,
+                                    jfloat close_alpha,
+                                    jfloat close_btn_width,
+                                    jfloat static_to_view_blend,
+                                    jfloat border_scale,
+                                    jfloat saturation,
+                                    jfloat brightness,
+                                    jboolean show_toolbar,
+                                    jint default_theme_color,
+                                    jint toolbar_background_color,
+                                    jint close_button_color,
+                                    jboolean anonymize_toolbar,
+                                    jboolean show_tab_title,
+                                    jint toolbar_textbox_resource_id,
+                                    jint toolbar_textbox_background_color,
+                                    jfloat toolbar_textbox_alpha,
+                                    jfloat toolbar_alpha,
+                                    jfloat toolbar_y_offset,
+                                    jfloat side_border_scale,
+                                    jboolean inset_border) {
   scoped_refptr<TabLayer> layer;
   auto iter = tab_map_.find(id);
   if (iter != tab_map_.end()) {
     layer = iter->second;
   } else {
     layer = TabLayer::Create(incognito, resource_manager_, layer_title_cache_,
                              tab_content_manager_);
     tab_map_.insert(TabMap::value_type(id, layer));
   }
   own_tree_->AddChild(layer->layer());
   visible_tabs_this_frame_.insert(id);
 
   // Add the tints for the border asset and close icon to the list that was
   // used for this frame.
   used_tints_.insert(toolbar_background_color);
   used_tints_.insert(close_button_color);
 
   DCHECK(layer);
   if (layer) {
     layer->SetProperties(
-        id, can_use_live_layer, browser_controls_at_bottom,
-        toolbar_resource_id, close_button_resource_id,
-        shadow_resource_id, contour_resource_id, back_logo_resource_id,
-        border_resource_id, border_inner_shadow_resource_id,
-        tab_background_color, back_logo_color, is_portrait, x, y, width, height,
-        shadow_x, shadow_y, shadow_width, shadow_height, pivot_x, pivot_y,
-        rotation_x, rotation_y, alpha, border_alpha, border_inner_shadow_alpha,
-        contour_alpha, shadow_alpha, close_alpha, border_scale, saturation,
-        brightness, close_btn_width, static_to_view_blend, content_width,
-        content_height, content_width, visible_content_height, show_toolbar,
-        default_theme_color, toolbar_background_color,
-        close_button_color, anonymize_toolbar, show_tab_title,
-        toolbar_textbox_resource_id, toolbar_textbox_background_color,
-        toolbar_textbox_alpha, toolbar_alpha, toolbar_y_offset,
-        side_border_scale, inset_border);
+        id, can_use_live_layer, browser_controls_at_bottom, toolbar_resource_id,
+        close_button_resource_id, shadow_resource_id, contour_resource_id,
+        back_logo_resource_id, border_resource_id,
+        border_inner_shadow_resource_id, tab_background_color, back_logo_color,
+        is_portrait, x, y, width, height, shadow_x, shadow_y, shadow_width,
+        shadow_height, pivot_x, pivot_y, rotation_x, rotation_y, alpha,
+        border_alpha, border_inner_shadow_alpha, contour_alpha, shadow_alpha,
+        close_alpha, border_scale, saturation, brightness, close_btn_width,
+        static_to_view_blend, content_width, content_height, content_width,
+        visible_content_height, show_toolbar, default_theme_color,
+        toolbar_background_color, close_button_color, anonymize_toolbar,
+        show_tab_title, toolbar_textbox_resource_id,
+        toolbar_textbox_background_color, toolbar_textbox_alpha, toolbar_alpha,
+        toolbar_y_offset, side_border_scale, inset_border);
   }
 
   gfx::RectF self(own_tree_->position(), gfx::SizeF(own_tree_->bounds()));
   gfx::RectF content(x, y, width, height);
 
   content_obscures_self_ |= content.Contains(self);
 }
 
 base::android::ScopedJavaLocalRef<jobject> TabListSceneLayer::GetJavaObject(
     JNIEnv* env) {
@@ skipping 19 matching lines @@
   // This will automatically bind to the Java object and pass ownership there.
   TabListSceneLayer* scene_layer = new TabListSceneLayer(env, jobj);
   return reinterpret_cast<intptr_t>(scene_layer);
 }
 
 bool RegisterTabListSceneLayer(JNIEnv* env) {
   return RegisterNativesImpl(env);
 }
 
 }  // namespace android