Hide fullscreen rotation jank

content/browser/renderer_host/render_widget_host_view_base.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 387 matching lines @@
 
   // Called by the RenderWidgetHost when an ambiguous gesture is detected to
   // show the disambiguation popup bubble.
   virtual void ShowDisambiguationPopup(const gfx::Rect& rect_pixels,
                                        const SkBitmap& zoomed_bitmap);
 
   // Called by the WebContentsImpl when a user tries to navigate a new page on
   // main frame.
   virtual void OnDidNavigateMainFrameToNewPage();
 
+  // Called by the WebContentsImpl when the fullscreen state is changed.
+  virtual void OnFullscreenStateChanged(bool is_fullscreen) {}

[boliu, 2017/06/20 20:54:44]

how is this different from the is_fullscreen thing on line 434?

[steimel, 2017/06/22 01:32:11]

Right now, the is_fullscreen stuff is used in RenderWidgetHostViewAura to keep
track of when it's initialized as fullscreen. This here is an event handler to
give a way for WebContents to notify us of fullscreen changes. I could
potentially re-use the is_fullscreen_ bool to store the result (as opposed to
web_contents_is_fullscreen_), but I'm not sure of the side-effects and don't
want to make one bool do two things even if for two different subclasses.

[boliu, 2017/06/23 01:51:42]

My problem is that this is just too confusing. Having two "fullscreen" things in
one class that are not referring to the same thing.

Looks like is_fullscreen_ is only used by aura. RenderWidgetHostViewEventHandler
is an aura-only class too, so maybe it can use RWHVAura directly. So then
is_fullscreen_ can be moved into RWHVAura? Separate CL though

Also I concur with the other comment, should use
RWHDelegate::IsFullscreenForCurrentTab instead of adding this.

[Khushal, 2017/06/23 03:09:50]

Agreed. I think the function will still be needed to notify the view when the
fullscreen state changes but the current state can be queried using RWHDelegate
method.

[steimel, 2017/06/29 00:38:50]

Changed to not have is_fullscreen param, but as Khushal mentioned this function
is still necessary for RWHVA to get notified of changes to fullscreen state

+
   // Called by WebContentsImpl to notify the view about a change in visibility
   // of context menu. The view can then perform platform specific tasks and
   // changes.
   virtual void SetShowingContextMenu(bool showing) {}
 
   // Add and remove observers for lifetime event notifications. The order in
   // which notifications are sent to observers is undefined. Clients must be
   // sure to remove the observer before they go away.
   void AddObserver(RenderWidgetHostViewBaseObserver* observer);
   void RemoveObserver(RenderWidgetHostViewBaseObserver* observer);
@@ skipping 75 matching lines @@
   base::ObserverList<RenderWidgetHostViewBaseObserver> observers_;
 
   base::WeakPtrFactory<RenderWidgetHostViewBase> weak_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewBase);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_BASE_H_