Hide fullscreen rotation jank

content/browser/renderer_host/render_widget_host_view_android.h

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_
 #define CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_
 
 #include <stddef.h>
 #include <stdint.h>
 
@@ skipping 220 matching lines @@
   void ReclaimResources(const cc::ReturnedResourceArray& resources) override;
 
   // cc::BeginFrameObserver implementation.
   void OnBeginFrame(const cc::BeginFrameArgs& args) override;
   const cc::BeginFrameArgs& LastUsedBeginFrameArgs() const override;
   void OnBeginFrameSourcePausedChanged(bool paused) override;
 
   // Non-virtual methods
   void SetContentViewCore(ContentViewCoreImpl* content_view_core);
   SkColor GetCachedBackgroundColor() const;
+  bool CanShowThumbnailPlaceholder() const;
   void SendKeyEvent(const NativeWebKeyboardEvent& event);
   void SendMouseEvent(const ui::MotionEventAndroid&, int action_button);
   void SendMouseWheelEvent(const blink::WebMouseWheelEvent& event);
   void SendGestureEvent(const blink::WebGestureEvent& event);
   void ResolveTapDisambiguation(double timestamp_seconds,
                                 gfx::Point tap_viewport_offset,
                                 bool is_long_press);
   void set_ime_adapter(ImeAdapterAndroid* ime_adapter) {
     ime_adapter_android_ = ime_adapter;
   }
   void set_selection_popup_controller(SelectionPopupController* controller) {
     selection_popup_controller_ = controller;
   }
 
   base::WeakPtr<RenderWidgetHostViewAndroid> GetWeakPtrAndroid();
 
   bool OnTouchEvent(const ui::MotionEvent& event);
   bool OnTouchHandleEvent(const ui::MotionEvent& event);
   int GetTouchHandleHeight();
   void ResetGestureDetection();
   void SetDoubleTapSupportEnabled(bool enabled);
   void SetMultiTouchZoomSupportEnabled(bool enabled);
 
   void WasResized();
 
+  void OnFullscreenStateChanged(bool entered_fullscreen) override;

[Khushal, 2017/06/15 18:42:55]

nit: Put this with the rest of the RWHV overrides.

[steimel, 2017/06/15 21:46:38]

Done.

+
   bool HasValidFrame() const;
 
   void MoveCaret(const gfx::Point& point);
   void ShowContextMenuAtPoint(const gfx::Point& point, ui::MenuSourceType);
   void DismissTextHandles();
   void SetTextHandlesTemporarilyHidden(bool hidden);
   void OnShowUnhandledTapUIIfNeeded(int x_dip, int y_dip);
   void OnSelectWordAroundCaretAck(bool did_select,
                                   int start_adjust,
                                   int end_adjust);
@@ skipping 21 matching lines @@
                               RenderWidgetHostViewBase* updated_view) override;
   void OnTextSelectionChanged(TextInputManager* text_input_manager,
                               RenderWidgetHostViewBase* updated_view) override;
 
   ImeAdapterAndroid* ime_adapter_for_testing() { return ime_adapter_android_; }
 
   // Exposed for tests.
   cc::SurfaceId SurfaceIdForTesting() const override;
 
  private:
+  enum class FullscreenState {
+    kNotFullscreen,
+    kEnteringFullscreen,
+    kFullscreen,
+    kExitingFullscreen,
+    kFullscreenRotation,

[mlamouri (slow - plz ping), 2017/06/15 13:23:41]

Do we not care about rotation when not in fullscreen?

[Khushal, 2017/06/15 18:42:55]

In those case we just use the frame we have and use the page background color to
cover the gutter areas. That approach looks better for the not fullscreen case.

+  };
+
   void RunAckCallbacks();
 
   void SendReclaimCompositorResources(bool is_swap_ack);
 
   void OnFrameMetadataUpdated(const cc::CompositorFrameMetadata& frame_metadata,
                               bool is_transparent);
 
   void ShowInternal();
   void HideInternal();
   void AttachLayers();
@@ skipping 25 matching lines @@
   void RequestDisallowInterceptTouchEvent();
 
   bool SyncCompositorOnMessageReceived(const IPC::Message& message);
 
   void ComputeEventLatencyOSTouchHistograms(const ui::MotionEvent& event);
 
   void CreateOverscrollControllerIfPossible();
 
   WebContentsAccessibilityAndroid* GetWebContentsAccessibilityAndroid() const;
 
+  void UpdateFullscreenState(bool physical_backing_resized);
+
   // The model object.
   RenderWidgetHostImpl* host_;
 
   // The begin frame source being observed.  Null if none.
   cc::BeginFrameSource* begin_frame_source_;
   cc::BeginFrameArgs last_begin_frame_args_;
   uint32_t latest_confirmed_begin_frame_source_id_;
   uint64_t latest_confirmed_begin_frame_sequence_number_;
 
   // Indicates whether and for what reason a request for begin frames has been
@@ skipping 59 matching lines @@
   std::unique_ptr<viz::FrameEvictor> frame_evictor_;
 
   bool observing_root_window_;
 
   // The last scroll offset of the view.
   gfx::Vector2dF last_scroll_offset_;
 
   float prev_top_shown_pix_;
   float prev_bottom_shown_pix_;
 
+  FullscreenState fullscreen_state_ = FullscreenState::kNotFullscreen;
+
+  // While we could simply take a mismatch in fullscreen states as the trigger
+  // for a transition, and assume the transition to have finished once the
+  // fullscreen states and sizes match, we have cases where we reach this
+  // consistent state before the physical backing size changes. Therefore we
+  // defer assuming the transition to be completed until a resize event is
+  // received, which is marked by |fullscreen_transition_awaiting_resize_|.
+  //
+  // Note that this assumes that every transition will be followed by a change
+  // in the view's physical backing size.
+  bool fullscreen_transition_awaiting_resize_ = false;
+  bool current_frame_is_fullscreen_ = false;
+  bool web_contents_is_fullscreen_ = false;
+
   cc::mojom::MojoCompositorFrameSinkClient* renderer_compositor_frame_sink_ =
       nullptr;
 
   base::ObserverList<DestructionObserver> destruction_observers_;
 
   MouseWheelPhaseHandler mouse_wheel_phase_handler_;
 
   base::WeakPtrFactory<RenderWidgetHostViewAndroid> weak_ptr_factory_;
 
   DISALLOW_COPY_AND_ASSIGN(RenderWidgetHostViewAndroid);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_RENDER_WIDGET_HOST_VIEW_ANDROID_H_