Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(32)

Unified Diff: tools/binary_size/helpers.py

Issue 2810813003: Add resource_sizes diffs to diagnose_apk_bloat.py. (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: tools/binary_size/helpers.py
diff --git a/tools/binary_size/helpers.py b/tools/binary_size/helpers.py
index c82a6ba161947969f8ad128038b34271803fbfc5..c1f9f00f6cbf16250a9df5b4efbc78bd34ddf8fd 100644
--- a/tools/binary_size/helpers.py
+++ b/tools/binary_size/helpers.py
@@ -16,7 +16,7 @@ import sys
SRC_ROOT = os.path.dirname(os.path.dirname(os.path.dirname(__file__)))
-def AddCommonOptionsAndParseArgs(parser, argv, pypy_warn=True):
+def AddCommonOptionsAndParseArgs(parser, argv):
parser.add_argument('--no-pypy', action='store_true',
help='Do not automatically switch to pypy when available')
parser.add_argument('-v',
@@ -36,9 +36,7 @@ def AddCommonOptionsAndParseArgs(parser, argv, pypy_warn=True):
logging.debug('Switching to pypy.')
os.execv(pypy_path, [pypy_path] + sys.argv)
# NOTE! Running with python: 6s. Running with pypy: 3s
- if pypy_warn:
- logging.warning(
- 'This script runs more than 2x faster if you install pypy.')
+ logging.warning('This script runs more than 2x faster if you install pypy.')
if logging.getLogger().isEnabledFor(logging.DEBUG):
atexit.register(_LogPeakRamUsage)
« tools/binary_size/diagnose_apk_bloat.py ('K') | « tools/binary_size/diagnose_apk_bloat.py ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698