Issue 28108: Add an identity (id) to system drag & drop.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 28108: Add an identity (id) to system drag & drop. (Closed)

Created:
11 years, 10 months ago by noel.gordon

Modified:
9 years, 7 months ago

Reviewers:
tony

CC:
chromium-reviews_googlegroups.com

Base URL:
http://src.chromium.org/svn/trunk/src/

Visibility:
Public.

Description

Used for gears file drag & drop in chrome, assign a drag id (identity) to each drag and drop session. Send the identity to the renderer WebViewImpl in drag enter notifications, provide a getter method. BUG=7995

Patch Set 1 #

Patch Set 2 : '' #

Patch Set 3 : '' #

Patch Set 4 : '' #

Patch Set 5 : '' #

Created: 11 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+71 lines, -2 lines)			Patch
M	base/base_drop_target.h	View	1 2 3 4	2 chunks	+11 lines, -0 lines	0 comments	Download
M	base/base_drop_target.cc	View	1	2 chunks	+6 lines, -0 lines	0 comments	Download
M	chrome/browser/tab_contents/web_drop_target.cc	View		2 chunks	+7 lines, -1 line	0 comments	Download
M	chrome/common/render_messages.h	View		2 chunks	+2 lines, -0 lines	0 comments	Download
M	webkit/glue/webdropdata.h	View	1 2 3 4	1 chunk	+9 lines, -1 line	0 comments	Download
M	webkit/glue/webview.h	View	1	1 chunk	+1 line, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.h	View	1	2 chunks	+9 lines, -0 lines	0 comments	Download
M	webkit/glue/webview_impl.cc	View	1	2 chunks	+26 lines, -0 lines	0 comments	Download

Messages

Total messages: 4 (0 generated)

Expand Messages | Collapse Messages

tony

Overall, LGTM. Why not just use a int with -1 as the special value? We ...

11 years, 10 months ago (2009-02-25 20:59:10 UTC) #2

tony

11 years, 10 months ago (2009-02-26 01:29:43 UTC) #4

Committed as r10430 via http://codereview.chromium.org/28158/show

Expand Messages | Collapse Messages