Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(215)

Unified Diff: ios/chrome/browser/test/perf_test_with_bvc_ios.mm

Issue 2810743002: [ios] Refactor SessionServiceIOS to remove dependency on BrowserState. (Closed)
Patch Set: Fix a typo in SessionServiceIOS initializer's comment. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_unittest.mm ('k') | ios/chrome/browser/ui/main/browser_view_wrangler.mm » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/chrome/browser/test/perf_test_with_bvc_ios.mm
diff --git a/ios/chrome/browser/test/perf_test_with_bvc_ios.mm b/ios/chrome/browser/test/perf_test_with_bvc_ios.mm
index 71faaabb042af4e0a7dc5d76e2a9379640eee21a..146c521a2561eaea18f8de067fc7442b96feee95 100644
--- a/ios/chrome/browser/test/perf_test_with_bvc_ios.mm
+++ b/ios/chrome/browser/test/perf_test_with_bvc_ios.mm
@@ -116,17 +116,19 @@ void PerfTestWithBVC::SetUp() {
chrome_browser_state_.get());
// Use the session to create a window which will contain the tab models.
- SessionWindowIOS* sessionWindow = [[SessionServiceIOS sharedService]
- loadWindowForBrowserState:chrome_browser_state_.get()];
+ NSString* state_path = base::SysUTF8ToNSString(
+ chrome_browser_state_->GetStatePath().AsUTF8Unsafe());
+ SessionWindowIOS* session_window = [[SessionServiceIOS sharedService]
+ loadSessionWindowFromDirectory:state_path];
// Tab models. The off-the-record (OTR) tab model is required for the stack
// view controller, which is created in OpenStackView().
tab_model_.reset([[TabModel alloc]
- initWithSessionWindow:sessionWindow
+ initWithSessionWindow:session_window
sessionService:[SessionServiceIOS sharedService]
browserState:chrome_browser_state_.get()]);
otr_tab_model_.reset([[TabModel alloc]
- initWithSessionWindow:sessionWindow
+ initWithSessionWindow:session_window
sessionService:[SessionServiceIOS sharedService]
browserState:chrome_browser_state_
->GetOffTheRecordChromeBrowserState()]);
« no previous file with comments | « ios/chrome/browser/tabs/tab_model_unittest.mm ('k') | ios/chrome/browser/ui/main/browser_view_wrangler.mm » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698