ios/chrome/browser/tabs/tab_model.mm - Issue 2810743002: [ios] Refactor SessionServiceIOS to remove dependency on BrowserState.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ios/chrome/browser/tabs/tab_model.mm

Issue 2810743002: [ios] Refactor SessionServiceIOS to remove dependency on BrowserState. (Closed)

Patch Set: Fix a typo in SessionServiceIOS initializer's comment. Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ios/chrome/browser/tabs/tab_model.mm

diff --git a/ios/chrome/browser/tabs/tab_model.mm b/ios/chrome/browser/tabs/tab_model.mm

index 66fec7ea6832d49bb8fe5f8a0de13307752c4c0e..807360e6113b278249203328005b9894511c1930 100644

--- a/ios/chrome/browser/tabs/tab_model.mm

+++ b/ios/chrome/browser/tabs/tab_model.mm

@@ -362,9 +362,11 @@ void CleanCertificatePolicyCache(

// a transitional state.

if ((!self.currentTab && _webStateList->count()) || !_browserState)

return;

- [_sessionService saveWindow:self.windowForSavingSession

- forBrowserState:_browserState

- immediately:immediately];

+ NSString* statePath =

+ base::SysUTF8ToNSString(_browserState->GetStatePath().AsUTF8Unsafe());

+ [_sessionService saveSessionWindow:self.windowForSavingSession

+ directory:statePath

+ immediately:immediately];

}

- (Tab*)tabAtIndex:(NSUInteger)index {