tools/metrics/histograms/histograms.xml - Issue 2810733005: Hint about where to insert integer histogram enum values.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: tools/metrics/histograms/histograms.xml

Issue 2810733005: Hint about where to insert integer histogram enum values. (Closed)

Patch Set: Address comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: tools/metrics/histograms/histograms.xml

diff --git a/tools/metrics/histograms/histograms.xml b/tools/metrics/histograms/histograms.xml

index 72a733f9ef2639e6d54442cc13a124880be7ca6f..4282bbf4d79f4b6abbd52f794e965f67b496731c 100644

--- a/tools/metrics/histograms/histograms.xml

+++ b/tools/metrics/histograms/histograms.xml

@@ -100744,7 +100744,8 @@ http://cs/file:chrome/histograms.xml - but prefer this file for new entries.

Values in LoginCustomFlags are: value=(uint32_t)MD5(label).

This enum is verified by AboutFlagsHistogramTest unit test.

To add a new entry, add it with any unique value and run test to compute valid

-value.

+value. After that run tools/metrics/histograms/validate_format.py to find out

+where the value should be inserted to maintain ordering.

Don't remove entries when removing a flag, they are still used to decode data

from previous Chrome versions.

-->