Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(296)

Unified Diff: content/browser/renderer_host/offscreen_canvas_provider_impl.cc

Issue 2810703004: Add observers to FrameSinkManagerHost. (Closed)
Patch Set: Make more better. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/browser/renderer_host/offscreen_canvas_provider_impl.cc
diff --git a/content/browser/renderer_host/offscreen_canvas_provider_impl.cc b/content/browser/renderer_host/offscreen_canvas_provider_impl.cc
index 7e9567aa75ff46b6d98ba106223d798778c43c49..5b5d0ff9eb017510d2070951b86e678cd8551b4b 100644
--- a/content/browser/renderer_host/offscreen_canvas_provider_impl.cc
+++ b/content/browser/renderer_host/offscreen_canvas_provider_impl.cc
@@ -4,8 +4,6 @@
#include "content/browser/renderer_host/offscreen_canvas_provider_impl.h"
-#include "content/browser/compositor/surface_utils.h"
-#include "content/browser/renderer_host/offscreen_canvas_compositor_frame_sink_manager.h"
#include "content/browser/renderer_host/offscreen_canvas_surface_impl.h"
namespace content {
@@ -21,6 +19,11 @@ void OffscreenCanvasProviderImpl::Add(
bindings_.AddBinding(this, std::move(request));
}
+void OffscreenCanvasProviderImpl::DestroyOffscreenCanvasSurface(
+ const cc::FrameSinkId& frame_sink_id) {
+ surfaces_.erase(frame_sink_id);
+}
+
void OffscreenCanvasProviderImpl::CreateOffscreenCanvasSurface(
const cc::FrameSinkId& parent_frame_sink_id,
const cc::FrameSinkId& frame_sink_id,
@@ -36,8 +39,9 @@ void OffscreenCanvasProviderImpl::CreateOffscreenCanvasSurface(
return;
}
- OffscreenCanvasSurfaceImpl::Create(parent_frame_sink_id, frame_sink_id,
- std::move(client), std::move(request));
+ surfaces_[frame_sink_id] = base::MakeUnique<OffscreenCanvasSurfaceImpl>(
+ parent_frame_sink_id, frame_sink_id, this, std::move(client),
+ std::move(request));
}
void OffscreenCanvasProviderImpl::CreateCompositorFrameSink(
@@ -50,15 +54,13 @@ void OffscreenCanvasProviderImpl::CreateCompositorFrameSink(
return;
}
- // TODO(kylechar): Add test for bad |frame_sink_id|.
- auto* manager = OffscreenCanvasCompositorFrameSinkManager::GetInstance();
- auto* surface_impl = manager->GetSurfaceInstance(frame_sink_id);
- if (!surface_impl) {
+ auto iter = surfaces_.find(frame_sink_id);
+ if (iter == surfaces_.end()) {
DLOG(ERROR) << "No OffscreenCanvasSurfaceImpl for " << frame_sink_id;
return;
}
- surface_impl->CreateCompositorFrameSink(std::move(client),
+ iter->second->CreateCompositorFrameSink(std::move(client),
std::move(request));
}

Powered by Google App Engine
This is Rietveld 408576698