Add observers to FrameSinkManagerHost.

content/browser/renderer_host/offscreen_canvas_provider_impl.h

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #ifndef CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_PROVIDER_IMPL_H_
 #define CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_PROVIDER_IMPL_H_
 
+#include <memory>
+#include <unordered_map>
+
 #include "cc/surfaces/frame_sink_id.h"
+#include "content/common/content_export.h"
 #include "mojo/public/cpp/bindings/binding_set.h"
 #include "third_party/WebKit/public/platform/modules/offscreencanvas/offscreen_canvas_surface.mojom.h"
 
 namespace content {
 
+class OffscreenCanvasSurfaceImpl;
+
 // Creates OffscreenCanvasSurfaces and MojoCompositorFrameSinks for a renderer.
-class OffscreenCanvasProviderImpl
+class CONTENT_EXPORT OffscreenCanvasProviderImpl
     : public blink::mojom::OffscreenCanvasProvider {
  public:
   explicit OffscreenCanvasProviderImpl(uint32_t renderer_client_id);
   ~OffscreenCanvasProviderImpl() override;
 
   void Add(blink::mojom::OffscreenCanvasProviderRequest request);
 
+  void DestroyOffscreenCanvasSurface(const cc::FrameSinkId& frame_sink_id);

[Fady Samuel, 2017/04/28 04:58:00]

Should this be passed by value to avoid use-after-free?

[kylechar, 2017/05/01 19:07:48]

Done.

+
   // blink::mojom::OffscreenCanvasProvider implementation.
   void CreateOffscreenCanvasSurface(
       const cc::FrameSinkId& parent_frame_sink_id,
       const cc::FrameSinkId& frame_sink_id,
       blink::mojom::OffscreenCanvasSurfaceClientPtr client,
       blink::mojom::OffscreenCanvasSurfaceRequest request) override;
   void CreateCompositorFrameSink(
       const cc::FrameSinkId& frame_sink_id,
       cc::mojom::MojoCompositorFrameSinkClientPtr client,
       cc::mojom::MojoCompositorFrameSinkRequest request) override;
 
  private:
+  friend class OffscreenCanvasProviderImplTest;
+
   // FrameSinkIds for offscreen canvas must use the renderer client id.
   const uint32_t renderer_client_id_;
 
   mojo::BindingSet<blink::mojom::OffscreenCanvasProvider> bindings_;
 
+  std::unordered_map<cc::FrameSinkId,
+                     std::unique_ptr<OffscreenCanvasSurfaceImpl>,
+                     cc::FrameSinkIdHash>
+      surfaces_;

[Fady Samuel, 2017/04/28 04:58:00]

I hate how we're overloading the term surface here :(

[kylechar, 2017/05/01 19:07:48]

Agreed. I think it should be OffscreenCanvasSurfaceImpl => OffscreenCanvasImpl.

+
   DISALLOW_COPY_AND_ASSIGN(OffscreenCanvasProviderImpl);
 };
 
 }  // namespace content
 
 #endif  // CONTENT_BROWSER_RENDERER_HOST_OFFSCREEN_CANVAS_PROVIDER_IMPL_H_