Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(541)

Unified Diff: pkg/compiler/lib/src/ssa/builder.dart

Issue 2810683002: Use entities in Selector methods (Closed)
Patch Set: Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: pkg/compiler/lib/src/ssa/builder.dart
diff --git a/pkg/compiler/lib/src/ssa/builder.dart b/pkg/compiler/lib/src/ssa/builder.dart
index 0301d2c9d2fd80cac0721c0eaf1d6f7bc2e05d59..4f774d153ff0498439e687301ff1513e8a3e15c7 100644
--- a/pkg/compiler/lib/src/ssa/builder.dart
+++ b/pkg/compiler/lib/src/ssa/builder.dart
@@ -3069,8 +3069,9 @@ class SsaBuilder extends ast.Visitor
// TODO(5347): Try to avoid the need for calling [implementation] before
// calling [makeStaticArgumentList].
Selector selector = elements.getSelector(node);
- assert(invariant(node, selector.applies(method.implementation),
- message: "$selector does not apply to ${method.implementation}"));
+ MethodElement implementation = method.implementation;
+ assert(invariant(node, selector.applies(implementation),
+ message: "$selector does not apply to ${implementation}"));
List<HInstruction> inputs =
makeStaticArgumentList(selector.callStructure, node.arguments, method);
push(buildInvokeSuper(selector, method, inputs, sourceInformation));
@@ -4202,7 +4203,7 @@ class SsaBuilder extends ast.Visitor
}
void handleSuperSendSet(ast.SendSet node) {
- Element element = elements[node];
+ MemberElement element = elements[node];
List<HInstruction> setterInputs = <HInstruction>[];
void generateSuperSendSet() {
Selector setterSelector = elements.getSelector(node);
« no previous file with comments | « pkg/compiler/lib/src/elements/entities.dart ('k') | pkg/compiler/lib/src/universe/codegen_world_builder.dart » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698