Issue 2810683002: Use entities in Selector methods

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2810683002: Use entities in Selector methods (Closed)

Created:
3 years, 8 months ago by Johnni Winther

Modified:
3 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Use entities in Selector methods This makes these methods reusable for kernel based elements. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/e5bb7df19bb0249bae1c294305ec8d842cdf629b

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+25 lines, -33 lines)			Patch
M	pkg/compiler/lib/src/compiler.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	pkg/compiler/lib/src/elements/common.dart	View	3 chunks	+6 lines, -6 lines	0 comments	Download
M	pkg/compiler/lib/src/elements/elements.dart	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	pkg/compiler/lib/src/elements/entities.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	pkg/compiler/lib/src/ssa/builder.dart	View	2 chunks	+4 lines, -3 lines	0 comments	Download
M	pkg/compiler/lib/src/universe/codegen_world_builder.dart	View	2 chunks	+2 lines, -1 line	0 comments	Download
M	pkg/compiler/lib/src/universe/selector.dart	View	3 chunks	+6 lines, -16 lines	0 comments	Download
M	pkg/compiler/lib/src/world.dart	View	2 chunks	+3 lines, -4 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 8 months ago (2017-04-11 08:23:28 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
e5bb7df19bb0249bae1c294305ec8d842cdf629b (presubmit successful).