Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(106)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2810633003: Add kernel/closed_world2_test (Closed)

Created:
3 years, 8 months ago by Johnni Winther
Modified:
3 years, 8 months ago
Reviewers:
Emily Fortuna
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Add kernel/closed_world2_test This is a step towared computing the closed world purely from kernel based elements. The added test runs the resolution enqueuer on a kernel based world. Some methods and classes are mocked and no closed world object is computed, yet. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/ad52db16e022f6debcd04a0a403192027d805b07

Patch Set 1 #

Patch Set 2 : Small change #

Patch Set 3 : Add TODOs. #

Total comments: 2
Unified diffs Side-by-side diffs Delta from patch set Stats (+615 lines, -106 lines) Patch
M pkg/compiler/lib/src/common/backend_api.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/common_elements.dart View 2 chunks +7 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/compiler.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/elements/types.dart View 7 chunks +102 lines, -0 lines 0 comments Download
M pkg/compiler/lib/src/js_backend/impact_transformer.dart View 2 chunks +1 line, -3 lines 0 comments Download
M pkg/compiler/lib/src/kernel/elements.dart View 2 chunks +4 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/kernel/native_class_resolver.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M pkg/compiler/lib/src/kernel/world_builder.dart View 13 chunks +106 lines, -28 lines 0 comments Download
M pkg/compiler/lib/src/native/enqueue.dart View 1 chunk +1 line, -1 line 0 comments Download
M pkg/compiler/lib/src/ssa/kernel_impact.dart View 1 chunk +0 lines, -1 line 0 comments Download
M pkg/compiler/lib/src/universe/resolution_world_builder.dart View 1 chunk +21 lines, -0 lines 2 comments Download
A tests/compiler/dart2js/kernel/closed_world2_test.dart View 1 2 1 chunk +328 lines, -0 lines 0 comments Download
M tests/compiler/dart2js/kernel/closed_world_test.dart View 5 chunks +38 lines, -65 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
Johnni Winther
3 years, 8 months ago (2017-04-10 13:57:12 UTC) #2
Emily Fortuna
lgtm https://codereview.chromium.org/2810633003/diff/40001/pkg/compiler/lib/src/universe/resolution_world_builder.dart File pkg/compiler/lib/src/universe/resolution_world_builder.dart (right): https://codereview.chromium.org/2810633003/diff/40001/pkg/compiler/lib/src/universe/resolution_world_builder.dart#newcode801 pkg/compiler/lib/src/universe/resolution_world_builder.dart:801: return null; throw instead?
3 years, 8 months ago (2017-04-10 19:50:58 UTC) #3
Johnni Winther
https://codereview.chromium.org/2810633003/diff/40001/pkg/compiler/lib/src/universe/resolution_world_builder.dart File pkg/compiler/lib/src/universe/resolution_world_builder.dart (right): https://codereview.chromium.org/2810633003/diff/40001/pkg/compiler/lib/src/universe/resolution_world_builder.dart#newcode801 pkg/compiler/lib/src/universe/resolution_world_builder.dart:801: return null; On 2017/04/10 19:50:58, Emily Fortuna wrote: > ...
3 years, 8 months ago (2017-04-11 07:58:58 UTC) #4
Johnni Winther
3 years, 8 months ago (2017-04-11 08:33:57 UTC) #6
Message was sent while issue was closed. 
Committed patchset #3 (id:40001) manually as
ad52db16e022f6debcd04a0a403192027d805b07 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698