Add EnumerateMountEntries method in CrosDisksClient.

Add EnumerateMountEntries method in CrosDisksClient.

The corresponding dbus level method is already added in
https://chromium-review.googlesource.com/#/c/195111/.
This CL is for adding the method to the wrapper client class.

BUG=356583
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=270958

[kinaba, 2014-05-14 06:57:56]

PTAL.

Needs https://chromium-review.googlesource.com/#/c/199688 to be landed for
making it work properly.

[stevenjb, 2014-05-14 17:45:10]

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
File chromeos/dbus/cros_disks_client.cc (right):

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
chromeos/dbus/cros_disks_client.cc:811: bool
MountEntry::ReadFromDbus(dbus::MessageReader* reader, MountEntry* entry) {
If this is only used in this file we can just make it a file local method in an
anonymous namespace, ReadMountEntryFromDbus.

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
chromeos/dbus/cros_disks_client.h:189: class CHROMEOS_EXPORT MountEntry {
This could actually just be a struct since it doesn't contain any non-static
member functions. The constructors can be inlined.

[kinaba, 2014-05-15 02:14:59]

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
File chromeos/dbus/cros_disks_client.cc (right):

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
chromeos/dbus/cros_disks_client.cc:811: bool
MountEntry::ReadFromDbus(dbus::MessageReader* reader, MountEntry* entry) {
On 2014/05/14 17:45:11, stevenjb wrote:
> If this is only used in this file we can just make it a file local method in
an
> anonymous namespace, ReadMountEntryFromDbus.

Done.

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/281063002/diff/20001/chromeos/dbus/cros_disks...
chromeos/dbus/cros_disks_client.h:189: class CHROMEOS_EXPORT MountEntry {
On 2014/05/14 17:45:11, stevenjb wrote:
> This could actually just be a struct since it doesn't contain any non-static
> member functions. The constructors can be inlined.

Done.

[stevenjb, 2014-05-15 17:26:44]

lgtm w/ one fix

https://codereview.chromium.org/281063002/diff/60001/chromeos/dbus/cros_disks...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/281063002/diff/60001/chromeos/dbus/cros_disks...
chromeos/dbus/cros_disks_client.h:205: static bool
ReadFromDbus(dbus::MessageReader* reader, MountEntry* entry);
elim

[kinaba, 2014-05-16 01:46:18]

https://codereview.chromium.org/281063002/diff/60001/chromeos/dbus/cros_disks...
File chromeos/dbus/cros_disks_client.h (right):

https://codereview.chromium.org/281063002/diff/60001/chromeos/dbus/cros_disks...
chromeos/dbus/cros_disks_client.h:205: static bool
ReadFromDbus(dbus::MessageReader* reader, MountEntry* entry);
On 2014/05/15 17:26:44, stevenjb wrote:
> elim

Oops. Done.

[kinaba, 2014-05-16 04:29:20]

@benchan, could you take a look to make sure that the current CL correctly
matches your change in cros-disks?

[Ben Chan, 2014-05-16 05:44:04]

lgtm

[kinaba, 2014-05-16 05:44:38]

On 2014/05/16 05:44:04, Ben Chan wrote:
> lgtm

Thanks!

[kinaba, 2014-05-16 05:44:42]

The CQ bit was checked by kinaba@chromium.org

[commit-bot: I haz the power, 2014-05-16 05:44:47]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/kinaba@chromium.org/281063002/80001

[commit-bot: I haz the power, 2014-05-16 07:58:01]

Change committed as 270958