[ios clean] Adds ToolsMenu to TabGrid

ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "ios/clean/chrome/browser/ui/tab_grid/tab_grid_toolbar.h"
 
+#import "base/mac/foundation_util.h"
 #import "ios/clean/chrome/browser/ui/tab_grid/ui_stack_view+cr_tab_grid.h"
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 namespace {
 const CGFloat kToolbarHeight = 44.0f;
 }
 
+@interface TabGridToolbar ()
+@property(nonatomic, strong) UIStackView* toolbarContent;

[edchin, 2017/04/10 05:50:57]

Since this is added as a subview, it can be weak. This is preferred by marq.

[sczs, 2017/04/11 18:47:59]

Done.

+@end
+
 @implementation TabGridToolbar
 
+@synthesize toolbarContent = _toolbarContent;
+
 - (instancetype)init {
   if (self = [super init]) {
     UIVisualEffect* blurEffect =
         [UIBlurEffect effectWithStyle:UIBlurEffectStyleDark];
     UIVisualEffectView* toolbarView =
         [[UIVisualEffectView alloc] initWithEffect:blurEffect];
     toolbarView.autoresizingMask =
         UIViewAutoresizingFlexibleWidth | UIViewAutoresizingFlexibleHeight;
     [self addSubview:toolbarView];
 
-    UIStackView* toolbarContent = [UIStackView cr_tabGridToolbarStackView];
-    [toolbarView.contentView addSubview:toolbarContent];
+    self.toolbarContent = [UIStackView cr_tabGridToolbarStackView];
+    [toolbarView.contentView addSubview:self.toolbarContent];
 
     // Sets the stackview to a fixed height, anchored to the bottom of the
     // blur view.
-    toolbarContent.translatesAutoresizingMaskIntoConstraints = NO;
+    self.toolbarContent.translatesAutoresizingMaskIntoConstraints = NO;

[edchin, 2017/04/10 05:50:57]

Use direct access in partially constructed states. Not sure if this is required
in our style guide.

[marq (ping after 24h), 2017/04/10 11:36:39]

It's not explicitly defined, but it's a widely-accepted best practice.

[sczs, 2017/04/11 18:47:59]

Done.

     [NSLayoutConstraint activateConstraints:@[
-      [toolbarContent.heightAnchor constraintEqualToConstant:kToolbarHeight],
-      [toolbarContent.leadingAnchor
+      [self.toolbarContent.heightAnchor
+          constraintEqualToConstant:kToolbarHeight],
+      [self.toolbarContent.leadingAnchor
           constraintEqualToAnchor:toolbarView.contentView.leadingAnchor],
-      [toolbarContent.trailingAnchor
+      [self.toolbarContent.trailingAnchor
           constraintEqualToAnchor:toolbarView.contentView.trailingAnchor],
-      [toolbarContent.bottomAnchor
+      [self.toolbarContent.bottomAnchor
           constraintEqualToAnchor:toolbarView.contentView.bottomAnchor]
     ]];
   }
   return self;
 }
 
+#pragma mark - ZoomTransitionDelegate
+
+- (CGRect)rectForZoomWithKey:(NSObject*)key inView:(UIView*)view {
+  UIButton* menuButton = base::mac::ObjCCastStrict<UIButton>(
+      [self.toolbarContent.arrangedSubviews lastObject]);

[edchin, 2017/04/10 05:50:57]

Feel free to move the stackview construction and buttons to this file so that
you have access to the button directly. 

[sczs, 2017/04/11 18:47:59]

Acknowledged.

+  CGRect rect = [view convertRect:menuButton.bounds fromView:menuButton];
+  return rect;
+}
+
 #pragma mark - UIView
 
 // Returns an intrinsic height so that explicit height constraints are
 // not necessary. Status bar conditional logic can be set using this
 // intrinsic size.
 - (CGSize)intrinsicContentSize {
   return CGSizeMake(UIViewNoIntrinsicMetric, kToolbarHeight);
 }
 
 @end