Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(421)

Unified Diff: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp

Issue 2810593002: Set plugin focus by implementing HTMLPlugInElement::SetFocused. (Closed)
Patch Set: HTMLFrameOwnerElement::SetFocused rather than Node::SetFocused Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLPlugInElement.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
diff --git a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
index 7e1a51a703d1e1756c1575eb7e00812d6ef31b40..af79d2b86745e6c1fd7bb9903c9128f1dde1f3c7 100644
--- a/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
+++ b/third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
@@ -155,6 +155,14 @@ void HTMLPlugInElement::SetPersistedPlugin(PluginView* plugin) {
persisted_plugin_ = plugin;
}
+void HTMLPlugInElement::SetFocused(bool focused) {
+ // Set focus as kWebFocusTypeNone. The WebFocusType does not matter since
+ // it is not sent to the plugin in pepper_webplugin_impl::UpdateFocus.
+ if (plugin_)
+ plugin_->SetFocused(focused, kWebFocusTypeNone);
dcheng 2017/04/11 05:36:55 Can we remove the second argument?
joelhockey 2017/04/11 07:08:23 Done, also removed WebFocusType from the trail of
+ HTMLFrameOwnerElement::SetFocused(focused);
+}
+
bool HTMLPlugInElement::RequestObjectInternal(
const String& url,
const String& mime_type,
« no previous file with comments | « third_party/WebKit/Source/core/html/HTMLPlugInElement.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698