third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp - Issue 2810593002: Set plugin focus by implementing HTMLPlugInElement::SetFocused.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

Issue 2810593002: Set plugin focus by implementing HTMLPlugInElement::SetFocused. (Closed)

Patch Set: fix comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.h ('k') | third_party/WebKit/Source/core/html/shadow/DateTimeNumericFieldElement.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

diff --git a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

index 8ea2a29447aeea77d266b2fc83cc23be1e058ea5..05b925629e28ffa01689ed1dce6c451f8c9a84f3 100644

--- a/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

+++ b/third_party/WebKit/Source/core/html/shadow/DateTimeFieldElement.cpp

@@ -131,10 +131,16 @@ void DateTimeFieldElement::DefaultKeyboardEventHandler(

}

-void DateTimeFieldElement::SetFocused(bool value) {

- if (field_owner_)

- value ? field_owner_->DidFocusOnField() : field_owner_->DidBlurFromField();

- ContainerNode::SetFocused(value);

+void DateTimeFieldElement::SetFocused(bool value, WebFocusType focus_type) {

+ if (field_owner_) {

+ if (value) {

+ field_owner_->DidFocusOnField(focus_type);

+ } else {

+ field_owner_->DidBlurFromField(focus_type);

+ }

+ ContainerNode::SetFocused(value, focus_type);

}

void DateTimeFieldElement::FocusOnNextField() {