Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(119)

Unified Diff: third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp

Issue 2810593002: Set plugin focus by implementing HTMLPlugInElement::SetFocused. (Closed)
Patch Set: fix comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
diff --git a/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp b/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
index 349375c4f0018740d8d38c00c4b16cd7293bec54..ea10f0098425661dcb1d9175887af4adf7cfa42e 100644
--- a/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
+++ b/third_party/WebKit/Source/core/html/forms/MultipleFieldsTemporalInputTypeView.cpp
@@ -165,7 +165,8 @@ inline bool MultipleFieldsTemporalInputTypeView::ContainsFocusedShadowElement()
GetElement().GetDocument().FocusedElement());
}
-void MultipleFieldsTemporalInputTypeView::DidBlurFromControl() {
+void MultipleFieldsTemporalInputTypeView::DidBlurFromControl(
+ WebFocusType focus_type) {
// We don't need to call blur(). This function is called when control
// lost focus.
@@ -173,12 +174,13 @@ void MultipleFieldsTemporalInputTypeView::DidBlurFromControl() {
return;
EventQueueScope scope;
// Remove focus ring by CSS "focus" pseudo class.
- GetElement().SetFocused(false);
+ GetElement().SetFocused(false, focus_type);
if (SpinButtonElement* spin_button = GetSpinButtonElement())
spin_button->ReleaseCapture();
}
-void MultipleFieldsTemporalInputTypeView::DidFocusOnControl() {
+void MultipleFieldsTemporalInputTypeView::DidFocusOnControl(
+ WebFocusType focus_type) {
// We don't need to call focus(). This function is called when control
// got focus.
@@ -186,7 +188,7 @@ void MultipleFieldsTemporalInputTypeView::DidFocusOnControl() {
return;
// Add focus ring by CSS "focus" pseudo class.
// FIXME: Setting the focus flag to non-focused element is too tricky.
- GetElement().SetFocused(true);
+ GetElement().SetFocused(true, focus_type);
}
void MultipleFieldsTemporalInputTypeView::EditControlValueChanged() {

Powered by Google App Engine
This is Rietveld 408576698