Side by Side Diff
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Keyboard Shortcuts
File
u
:
up to issue
j
/
k
:
jump to file after / before current file
J
/
K
:
jump to next file with a comment after / before current file
Side-by-side diff
i
:
toggle intra-line diffs
e
:
expand all comments
c
:
collapse all comments
s
:
toggle showing all comments
n
/
p
:
next / previous diff chunk or comment
N
/
P
:
next / previous comment
<Up>
/
<Down>
:
next / previous line
Issue
u
:
up to list of issues
j
/
k
:
jump to patch after / before current patch
o
/
<Enter>
:
open current patch in side-by-side view
i
:
open current patch in unified diff view
Issue List
j
/
k
:
jump to issue after / before current issue
o
/
<Enter>
:
open current issue
Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr)
|
Please choose your nickname with
Settings
|
Help
|
Chromium Project
|
Gerrit Changes
|
Sign out
(181)
Issues
Search
My Issues
|
Starred
Open
|
Closed
|
All
Side by Side Diff: third_party/WebKit/LayoutTests/plugins/focus-change-2-change-focus-expected.txt
Issue
2810593002
:
Set plugin focus by implementing HTMLPlugInElement::SetFocused. (Closed)
Patch Set: HTMLFrameOwnerElement::SetFocused rather than Node::SetFocused
Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments.
Draft comments are only viewable by you.
Context:
3 lines
10 lines
25 lines
50 lines
75 lines
100 lines
Whole file
Column Width:
Tab Spaces:
Jump to:
third_party/WebKit/LayoutTests/plugins/focus-change-2-change-focus-expected.txt
third_party/WebKit/LayoutTests/plugins/focus-change-4-change-focus-and-blur-expected.txt
third_party/WebKit/Source/core/dom/Document.cpp
third_party/WebKit/Source/core/html/HTMLPlugInElement.h
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp
View unified diff
|
Download patch
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/plugins/focus-change-4-change-focus-and-blur-expected.txt »
('j') |
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp »
('J')
Toggle Intra-line Diffs
('i') |
Expand Comments
('e') |
Collapse Comments
('c') |
Show Comments
Hide Comments
('s')
OLD
NEW
1 CONSOLE MESSAGE: Blink Test Plugin: initializing
1 CONSOLE MESSAGE: Blink Test Plugin: initializing
2
CONSOLE MESSAGE: Blink Test Plugin: DidChangeFocus(true)
3
CONSOLE MESSAGE: Blink Test Plugin: DidChangeFocus(false)
2 i1focus
4 i1focus
3 i1blur
5 i1blur
4 pfocus-change-2
6 pfocus-change-2
5 pblur
7 pblur
6 i2focus
8 i2focus
7 i2blur
9 i2blur
8 i3focus
10 i3focus
9 PASS successfullyParsed is true
11 PASS successfullyParsed is true
10
12
11 TEST COMPLETE
13 TEST COMPLETE
12 Test changing focus inside plugin onfocus event
14 Test changing focus inside plugin onfocus event
13
15
14
16
OLD
NEW
« no previous file with comments
|
« no previous file
|
third_party/WebKit/LayoutTests/plugins/focus-change-4-change-focus-and-blur-expected.txt »
('j') |
third_party/WebKit/Source/core/html/HTMLPlugInElement.cpp »
('J')
Issue 2810593002: Set plugin focus by implementing HTMLPlugInElement::SetFocused. (Closed)
Created 3 years, 8 months ago by joelhockey
Modified 3 years, 8 months ago
Reviewers: dcheng, haraken
Base URL:
Comments: 2
This is Rietveld
408576698