Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(272)

Issue 281053003: Allow chromium url to be overwritten as a custom variable in DEPS. (Closed)

Created:
6 years, 7 months ago by Michael Achenbach
Modified:
6 years, 7 months ago
Reviewers:
danno, Jakob Kummerow
CC:
v8-dev
Visibility:
Public.

Description

Allow chromium url to be overwritten as a custom variable in DEPS. Using this work around, buildbot can set the chromium_url variable to the golo mirror. BUG=372738 LOG=n R=jkummerow@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=21296

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+7 lines, -3 lines) Patch
M DEPS View 1 chunk +7 lines, -3 lines 0 comments Download

Messages

Total messages: 4 (0 generated)
Michael Achenbach
PTAL
6 years, 7 months ago (2014-05-14 07:43:02 UTC) #1
Michael Achenbach
Note: The try jobs were useless as they apply the patch after 'gclient sync'. So ...
6 years, 7 months ago (2014-05-14 07:44:13 UTC) #2
Jakob Kummerow
lgtm
6 years, 7 months ago (2014-05-14 08:13:38 UTC) #3
Michael Achenbach
6 years, 7 months ago (2014-05-14 08:30:55 UTC) #4
Message was sent while issue was closed.
Committed patchset #1 manually as r21296 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698