Only store previous clip rects for PaintLayers that support subsequences.

third_party/WebKit/Source/core/paint/PrePaintTreeWalkTest.cpp

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "core/layout/LayoutTestHelper.h"
 #include "core/layout/LayoutTreeAsText.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/paint/ObjectPaintProperties.h"
 #include "core/paint/PaintLayer.h"
 #include "core/paint/PaintPropertyTreePrinter.h"
+#include "core/paint/PrePaintTreeWalk.h"
 #include "platform/graphics/paint/GeometryMapper.h"
 #include "platform/graphics/paint/ScrollPaintPropertyNode.h"
 #include "platform/graphics/paint/TransformPaintPropertyNode.h"
 #include "platform/testing/RuntimeEnabledFeaturesTestHelpers.h"
 #include "platform/testing/UnitTestHelpers.h"
 #include "platform/text/TextStream.h"
 #include "platform/wtf/HashMap.h"
 #include "platform/wtf/Vector.h"
 #include "testing/gtest/include/gtest/gtest.h"
 
 namespace blink {
 
-typedef bool TestParamRootLayerScrolling;
+typedef std::pair<bool, bool> SlimmingPaintAndRootLayerScrolling;
 class PrePaintTreeWalkTest
-    : public ::testing::WithParamInterface<TestParamRootLayerScrolling>,
+    : public ::testing::WithParamInterface<SlimmingPaintAndRootLayerScrolling>,
       private ScopedSlimmingPaintV2ForTest,
+      private ScopedSlimmingPaintInvalidationForTest,
       private ScopedRootLayerScrollingForTest,
       public RenderingTest {
  public:
   PrePaintTreeWalkTest()
-      : ScopedSlimmingPaintV2ForTest(true),
-        ScopedRootLayerScrollingForTest(GetParam()),
+      : ScopedSlimmingPaintV2ForTest(GetParam().second),
+        ScopedSlimmingPaintInvalidationForTest(true),
+        ScopedRootLayerScrollingForTest(GetParam().first),
         RenderingTest(EmptyLocalFrameClient::Create()) {}
 
   const TransformPaintPropertyNode* FramePreTranslation() {
     FrameView* frame_view = GetDocument().View();
     if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
       return frame_view->GetLayoutView()
           ->PaintProperties()
           ->PaintOffsetTranslation();
     }
     return frame_view->PreTranslation();
   }
 
   const TransformPaintPropertyNode* FrameScrollTranslation() {
     FrameView* frame_view = GetDocument().View();
     if (RuntimeEnabledFeatures::rootLayerScrollingEnabled()) {
       return frame_view->GetLayoutView()
           ->PaintProperties()
           ->ScrollTranslation();
     }
     return frame_view->ScrollTranslation();
   }
 
+ protected:
+  PaintLayer* GetPaintLayerByElementId(const char* id) {
+    return ToLayoutBoxModelObject(GetLayoutObjectByElementId(id))->Layer();
+  }
+
  private:
   void SetUp() override {
     Settings::SetMockScrollbarsEnabled(true);
 
     RenderingTest::SetUp();
     EnableCompositing();
   }
 
   void TearDown() override {
     RenderingTest::TearDown();
 
     Settings::SetMockScrollbarsEnabled(false);
   }
 };
 
-INSTANTIATE_TEST_CASE_P(All, PrePaintTreeWalkTest, ::testing::Bool());
+SlimmingPaintAndRootLayerScrolling g_prepaint_foo[] = {
+    SlimmingPaintAndRootLayerScrolling(false, false),
+    SlimmingPaintAndRootLayerScrolling(true, false),
+    SlimmingPaintAndRootLayerScrolling(false, true),
+    SlimmingPaintAndRootLayerScrolling(true, true)};
+
+INSTANTIATE_TEST_CASE_P(All,
+                        PrePaintTreeWalkTest,
+                        ::testing::ValuesIn(g_prepaint_foo));
 
 TEST_P(PrePaintTreeWalkTest, PropertyTreesRebuiltWithBorderInvalidation) {
   SetBodyInnerHTML(
       "<style>"
       "  body { margin: 0; }"
       "  #transformed { transform: translate(100px, 100px); }"
       "  .border { border: 10px solid black; }"
       "</style>"
       "<div id='transformed'></div>");
 
@@ skipping 47 matching lines @@
   // Invalidate the CSS transform property.
   transformed_element->setAttribute(HTMLNames::classAttr, "transformB");
   GetDocument().View()->UpdateAllLifecyclePhases();
 
   // The transform should have changed.
   EXPECT_EQ(TransformationMatrix().Translate(200, 200),
             transformed_properties->Transform()->Matrix());
 }
 
 TEST_P(PrePaintTreeWalkTest, PropertyTreesRebuiltWithOpacityInvalidation) {
+  // In SPv1 mode, we don't need or store property tree nodes for effects.
+  if (!RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    return;
   SetBodyInnerHTML(
       "<style>"
       "  .opacityA { opacity: 0.9; }"
       "  .opacityB { opacity: 0.4; }"
       "</style>"
       "<div id='transparent' class='opacityA'></div>");
 
   auto* transparent_element = GetDocument().GetElementById("transparent");
   const auto* transparent_properties =
       transparent_element->GetLayoutObject()->PaintProperties();
@@ skipping 57 matching lines @@
   EXPECT_TRUE(child_paint_layer->NeedsRepaint());
 }
 
 TEST_P(PrePaintTreeWalkTest, ClearSubsequenceCachingClipChangePosAbs) {
   SetBodyInnerHTML(
       "<style>"
       "  .clip { overflow: hidden }"
       "</style>"
       "<div id='parent' style='transform: translateZ(0); width: 100px;"
       "  height: 100px; position: absolute'>"
-      "  <div id='child' style='overflow: hidden; z-index: 0; width: 50px;"
-      "      height: 50px'>"
+      "  <div id='child' style='overflow: hidden; position: relative;"
+      "      z-index: 0; width: 50px; height: 50px'>"
       "    content"
       "  </div>"
       "</div>");
 
   auto* parent = GetDocument().GetElementById("parent");
   auto* child = GetDocument().GetElementById("child");
   auto* child_paint_layer =
       ToLayoutBoxModelObject(child->GetLayoutObject())->Layer();
   EXPECT_FALSE(child_paint_layer->NeedsRepaint());
   EXPECT_FALSE(child_paint_layer->NeedsPaintPhaseFloat());
@@ skipping 27 matching lines @@
   EXPECT_FALSE(child_paint_layer->NeedsPaintPhaseFloat());
 
   // This changes clips for absolute-positioned descendants of "child" but not
   // normal-position ones, which are already clipped to 50x50.
   parent->setAttribute(HTMLNames::classAttr, "clip");
   GetDocument().View()->UpdateAllLifecyclePhasesExceptPaint();
 
   EXPECT_TRUE(child_paint_layer->NeedsRepaint());
 }
 
+TEST_P(PrePaintTreeWalkTest, ClipRects) {
+  SetBodyInnerHTML(
+      "<div id='parent' style='isolation: isolate'>"
+      "  <div id='child' style='position: relative'>"
+      "    <div id='grandchild' style='isolation: isolate'>"
+      "      <div style='position: relative'></div>"
+      "    </div>"
+      "  </div>"
+      "</div>");
+
+  auto* parent = GetPaintLayerByElementId("parent");
+  auto* child = GetPaintLayerByElementId("child");
+  auto* grandchild = GetPaintLayerByElementId("grandchild");
+
+  EXPECT_TRUE(parent->PreviousPaintingClipRects());
+  EXPECT_FALSE(child->PreviousPaintingClipRects());
+  EXPECT_TRUE(grandchild->PreviousPaintingClipRects());
+
+  grandchild->ClearPreviousPaintingClipRects();
+  GetDocument().View()->UpdateAllLifecyclePhases();
+  // Still no rects, because the walk early-outed at the LayoutView.
+  EXPECT_FALSE(grandchild->PreviousPaintingClipRects());
+
+  grandchild->GetLayoutObject().SetNeedsPaintPropertyUpdate();
+  GetDocument().View()->UpdateAllLifecyclePhases();
+  EXPECT_TRUE(grandchild->PreviousPaintingClipRects());
+}
+
+TEST_P(PrePaintTreeWalkTest, VisualRectClipForceSubtree) {
+  SetBodyInnerHTML(
+      "<style>"
+      "  .heightClass { height: 100px !important }"

[pdr., 2017/04/13 16:21:45]

!important is a little confusing and there's an extra div in the example. Please
rewrite as:
  SetBodyInnerHTML(
      "<style>"
      "  #parent { height: 75px; width: 100px; position: relative; }"
      "</style>"
      "<div id='parent' style='height: 100px'>"
      "  <div id='child' style='overflow: hidden; width: 100%; height: 100%; "
      "                         position: relative;'>"
      "    <div id='grandchild' style='width: 50px; height: 200px;'></div>"
      "  </div>"
      "</div>");

  auto* grandchild = GetLayoutObjectByElementId("grandchild");

  // Remove the 100px height and fall back to a height of 75px.
  GetDocument().GetElementById("parent")->removeAttribute("style");
  ...

[chrishtr, 2017/04/13 17:15:38]

Done.

+      "  #parent { height: 75px }"
+      "</style>"
+      "<div id='parent' style='width: 100px; position: "
+      "relative' class='heightClass'>"
+      "  <div id='child' style='overflow: hidden; width: 100%; height: 100%; "
+      "      position: relative'>"
+      "    <div>"
+      "      <div id='grandchild' style='width: 50px; height: 200px; '>"
+      "      </div>"
+      "    </div>"
+      "  </div>"
+      "</div>");
+
+  auto* grandchild = GetLayoutObjectByElementId("grandchild");
+
+  GetDocument().GetElementById("parent")->removeAttribute("class");
+  GetDocument().View()->UpdateAllLifecyclePhases();
+
+  // In SPv2 mode, VisualRects are in the space of the containing transform
+  // node without applying any ancestor property nodes, including clip.
+  if (RuntimeEnabledFeatures::slimmingPaintV2Enabled())
+    EXPECT_EQ(200, grandchild->VisualRect().Height());
+  else
+    EXPECT_EQ(75, grandchild->VisualRect().Height());
+}
+
 }  // namespace blink