third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h - Issue 2810463002: Clean up DocumentMarkerController::copyMarkers() (now it's moveMarkers())

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

Issue 2810463002: Clean up DocumentMarkerController::copyMarkers() (now it's moveMarkers()) (Closed)

Patch Set: Actually do erase, fix reapply (messed up when rebasing) Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/editing/commands/SplitTextNodeCommand.cpp ('k') | third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

diff --git a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

index 73440cd7353a84d64d7353e3ed67a3a71141c0f4..398d743267b66a45f2ff01ec3d3850272d81f20d 100644

--- a/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

+++ b/third_party/WebKit/Source/core/editing/markers/DocumentMarkerController.h

@@ -74,11 +74,7 @@ class CORE_EXPORT DocumentMarkerController final

bool thick,

Color background_color);

- void CopyMarkers(Node* src_node,

- unsigned start_offset,

- int length,

- Node* dst_node,

- int delta);

+ void MoveMarkers(Node* src_node, int length, Node* dst_node);

void PrepareForDestruction();

// When a marker partially overlaps with range, if