Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(852)

Unified Diff: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java

Issue 2810433002: android: Async setupConnection binder call (Closed)
Patch Set: deflake test Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
diff --git a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
index 7e08d1ea0d8179ed27747d12859b198cd54960c9..ae5f9dfaeae11854a1254e2f1332273a097a13b7 100644
--- a/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
+++ b/content/public/android/javatests/src/org/chromium/content/browser/ChildProcessLauncherTest.java
@@ -445,7 +445,13 @@ public class ChildProcessLauncherTest extends InstrumentationTestCase {
assertFalse(conn.getService().bindToCaller());
assertEquals(1, retryConn.getServiceNumber());
- assertTrue(retryConn.getPid() > 0);
+ CriteriaHelper.pollInstrumentationThread(
+ new Criteria("Failed waiting retry connection to get pid") {
+ @Override
+ public boolean isSatisfied() {
+ return retryConn.getPid() > 0;
+ }
+ });
assertTrue(retryConn.getPid() != helperConnPid);
assertTrue(retryConn.getService().bindToCaller());
}
« no previous file with comments | « content/public/android/java/src/org/chromium/content/browser/ChildProcessConnectionImpl.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698