Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(223)

Unified Diff: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc

Issue 2810423003: Schedule bitmap animation timers on the compositor task runner. (Closed)
Patch Set: remove TODO comments from tests Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
diff --git a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
index 022f2cd8f4f22f2a2df17d90e3ef0e502b1e87e2..c41b04656b67b725bdf68ab0a3efc01e63d095ec 100644
--- a/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
+++ b/third_party/WebKit/Source/platform/scheduler/renderer/renderer_scheduler_impl_unittest.cc
@@ -835,9 +835,9 @@ TEST_F(RendererSchedulerImplTest, TestDefaultPolicy) {
EnableIdleTasks();
RunUntilIdle();
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("L1"), std::string("D1"),
- std::string("C1"), std::string("D2"),
- std::string("C2"), std::string("I1")));
+ testing::ElementsAre(std::string("C1"), std::string("C2"),
+ std::string("L1"), std::string("D1"),
+ std::string("D2"), std::string("I1")));
EXPECT_EQ(RendererSchedulerImpl::UseCase::NONE, CurrentUseCase());
}
@@ -1267,8 +1267,8 @@ TEST_F(RendererSchedulerImplTest,
// Note compositor tasks are not prioritized.
Sami 2017/05/04 00:33:38 This test is a little useless now, so let's change
Dan Elphick 2017/05/04 16:47:15 Added a new RunSlowCompositorTask method to Render
EXPECT_EQ(RendererSchedulerImpl::UseCase::NONE, CurrentUseCase());
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("D1"), std::string("C1"),
- std::string("D2"), std::string("C2"),
+ testing::ElementsAre(std::string("C1"), std::string("C2"),
+ std::string("D1"), std::string("D2"),
std::string("I1")));
}
@@ -1285,8 +1285,8 @@ TEST_F(RendererSchedulerImplTest,
// Note compositor tasks are not prioritized.
EXPECT_EQ(RendererSchedulerImpl::UseCase::NONE, CurrentUseCase());
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("D1"), std::string("C1"),
- std::string("D2"), std::string("C2"),
+ testing::ElementsAre(std::string("C1"), std::string("C2"),
+ std::string("D1"), std::string("D2"),
std::string("I1")));
}
@@ -1504,8 +1504,8 @@ TEST_F(RendererSchedulerImplTest,
RunUntilIdle();
// Note compositor tasks are not prioritized.
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("D1"), std::string("C1"),
- std::string("D2"), std::string("C2"),
+ testing::ElementsAre(std::string("C1"), std::string("C2"),
+ std::string("D1"), std::string("D2"),
std::string("I1")));
EXPECT_EQ(RendererSchedulerImpl::UseCase::NONE, CurrentUseCase());
}
@@ -1522,8 +1522,8 @@ TEST_F(RendererSchedulerImplTest,
RunUntilIdle();
// Note compositor tasks are not prioritized.
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("D1"), std::string("C1"),
- std::string("D2"), std::string("C2"),
+ testing::ElementsAre(std::string("C1"), std::string("C2"),
+ std::string("D1"), std::string("D2"),
std::string("I1")));
EXPECT_EQ(RendererSchedulerImpl::UseCase::NONE, CurrentUseCase());
// Note compositor tasks are not prioritized.
@@ -2359,7 +2359,7 @@ TEST_F(RendererSchedulerImplTest, SuspendRenderer) {
EnableIdleTasks();
RunUntilIdle();
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("D1"), std::string("C1"),
+ testing::ElementsAre(std::string("C1"), std::string("D1"),
std::string("I1")));
// The rest queued tasks fire when the tab goes foregrounded.
@@ -2391,7 +2391,7 @@ TEST_F(RendererSchedulerImplTest, ResumeRenderer) {
EnableIdleTasks();
RunUntilIdle();
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("D1"), std::string("C1"),
+ testing::ElementsAre(std::string("C1"), std::string("D1"),
std::string("I1")));
// The rest queued tasks fire when the renderer is resumed.
@@ -2409,7 +2409,7 @@ TEST_F(RendererSchedulerImplTest, ResumeRenderer) {
EnableIdleTasks();
RunUntilIdle();
EXPECT_THAT(run_order,
- testing::ElementsAre(std::string("D2"), std::string("C2"),
+ testing::ElementsAre(std::string("C2"), std::string("D2"),
std::string("I2")));
// The rest queued tasks fire when the renderer is resumed.

Powered by Google App Engine
This is Rietveld 408576698