Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(277)

Unified Diff: ios/chrome/search_widget_extension/BUILD.gn

Issue 2810403003: Add unit test and showcase support for search widget. (Closed)
Patch Set: rebase Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ios/chrome/search_widget_extension/BUILD.gn
diff --git a/ios/chrome/search_widget_extension/BUILD.gn b/ios/chrome/search_widget_extension/BUILD.gn
index 80a585f974b10b5e85b0f0199217989e69e6814f..00eb74453c63bfeb4b239ff8da19ca65abd02445 100644
--- a/ios/chrome/search_widget_extension/BUILD.gn
+++ b/ios/chrome/search_widget_extension/BUILD.gn
@@ -20,6 +20,23 @@ compile_plist("entitlements") {
}
ios_appex_bundle("search_widget_extension") {
+ deps = [
+ ":search_widget",
+ ]
+
+ extra_substitutions = [
+ "CHROME_CHANNEL_SCHEME=$url_channel_scheme",
+ "CHROMIUM_SHORT_NAME=$chromium_short_name",
+ "WIDGET_EXTENSION_BUNDLE_ID=$chromium_bundle_id.SearchTodayExtension",
+ ]
+
+ configs += [ "//build/config/compiler:enable_arc" ]
sdefresne 2017/04/19 15:54:56 There are no "sources" in that target, so you can
lody 2017/04/19 16:01:53 Done.
+
+ entitlements_target = ":entitlements"
+ info_plist_target = ":tweak_info_plist"
+}
+
+source_set("search_widget") {
sources = [
"search_widget_view.h",
"search_widget_view.mm",
@@ -30,17 +47,7 @@ ios_appex_bundle("search_widget_extension") {
deps = [
"//base",
"//components/open_from_clipboard:open_from_clipboard_impl",
- "//components/prefs",
- "//components/variations",
- "//components/version_info",
- "//ios/chrome/common",
"//ios/chrome/common/app_group",
- "//ios/chrome/common/app_group:client",
- "//ios/chrome/common/physical_web",
- "//ios/chrome/today_extension/strings",
- "//ios/third_party/material_components_ios",
- "//net",
- "//ui/base",
]
libs = [
@@ -49,14 +56,17 @@ ios_appex_bundle("search_widget_extension") {
"UIKit.framework",
]
- extra_substitutions = [
- "CHROME_CHANNEL_SCHEME=$url_channel_scheme",
- "CHROMIUM_SHORT_NAME=$chromium_short_name",
- "WIDGET_EXTENSION_BUNDLE_ID=$chromium_bundle_id.SearchTodayExtension",
- ]
-
configs += [ "//build/config/compiler:enable_arc" ]
+}
- entitlements_target = ":entitlements"
- info_plist_target = ":tweak_info_plist"
+source_set("unit_tests") {
+ testonly = true
+ sources = [
+ "search_widget_view_controller_unittest.mm",
+ ]
+ deps = [
+ ":search_widget",
+ "//testing/gtest",
+ ]
+ configs += [ "//build/config/compiler:enable_arc" ]
}

Powered by Google App Engine
This is Rietveld 408576698