Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(136)

Unified Diff: src/full-codegen/ia32/full-codegen-ia32.cc

Issue 2810363003: [builtins] Introduce DeleteProperty builtin (Closed)
Patch Set: fix CallableFor not to create handles Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/full-codegen/ia32/full-codegen-ia32.cc
diff --git a/src/full-codegen/ia32/full-codegen-ia32.cc b/src/full-codegen/ia32/full-codegen-ia32.cc
index e4d4284d9cdf8e6fd7d0d938d1588327287713ff..72e061acc69de9f00d4ddb5ccbdb2711b6f8eeba 100644
--- a/src/full-codegen/ia32/full-codegen-ia32.cc
+++ b/src/full-codegen/ia32/full-codegen-ia32.cc
@@ -2157,9 +2157,8 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {
if (property != NULL) {
VisitForStackValue(property->obj());
VisitForStackValue(property->key());
- CallRuntimeWithOperands(is_strict(language_mode())
- ? Runtime::kDeleteProperty_Strict
- : Runtime::kDeleteProperty_Sloppy);
+ PushOperand(Smi::FromInt(language_mode()));
+ CallRuntimeWithOperands(Runtime::kDeleteProperty);
context()->Plug(eax);
} else if (proxy != NULL) {
Variable* var = proxy->var();
@@ -2171,7 +2170,8 @@ void FullCodeGenerator::VisitUnaryOperation(UnaryOperation* expr) {
__ mov(eax, NativeContextOperand());
__ push(ContextOperand(eax, Context::EXTENSION_INDEX));
__ push(Immediate(var->name()));
- __ CallRuntime(Runtime::kDeleteProperty_Sloppy);
+ __ Push(Smi::FromInt(SLOPPY));
+ __ CallRuntime(Runtime::kDeleteProperty);
context()->Plug(eax);
} else {
DCHECK(!var->IsLookupSlot());
« no previous file with comments | « src/full-codegen/arm64/full-codegen-arm64.cc ('k') | src/full-codegen/mips/full-codegen-mips.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698