Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Unified Diff: headless/public/headless_browser.h

Issue 2810353003: Adds a command-line flag indicating an open and listening socket to (Closed)
Patch Set: Responded to dvallet's comments. Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: headless/public/headless_browser.h
diff --git a/headless/public/headless_browser.h b/headless/public/headless_browser.h
index 4b18f565b9e8fc2f2b8cb91ad0bb885a26a8a64e..baf8eac3e4a91d184aac76f0f8da74834ef86aad 100644
--- a/headless/public/headless_browser.h
+++ b/headless/public/headless_browser.h
@@ -102,9 +102,16 @@ struct HeadlessBrowser::Options {
const char** argv;
// Address at which DevTools should listen for connections. Disabled by
- // default.
+ // default. Mutually exclusive with devtools_socket_fd.
net::IPEndPoint devtools_endpoint;
+ // The fd of an already-open socket inherited from a parent process. Disabled
+ // by default. Mutually exclusive with devtools_endpoint.
+ size_t devtools_socket_fd;
+
+ // A single way to test whether the devtools server has been requested.
+ bool DevtoolsServerEnabled();
+
// Optional message pump that overrides the default. Must outlive the browser.
base::MessagePump* message_pump;
@@ -181,6 +188,7 @@ class HeadlessBrowser::Options::Builder {
// Browser-wide settings.
Builder& EnableDevToolsServer(const net::IPEndPoint& endpoint);
+ Builder& EnableDevToolsServer(const size_t socket_fd);
Builder& SetMessagePump(base::MessagePump* message_pump);
Builder& SetSingleProcessMode(bool single_process_mode);
Builder& SetDisableSandbox(bool disable_sandbox);

Powered by Google App Engine
This is Rietveld 408576698