Fix MaxCoefficient static variable value in Decimal.cpp

Fix MaxCoefficient static variable value in Decimal.cpp

Fix MaxCoefficient static variable value in Decimal.cpp to match the Precision
and the corresponding comment. We use 18 as precision and the comment says
MaxCoefficient should be 18 '9's in hexadecimal. However, 0x16345785D89FFFF is
99999999999999999 (17 '9's), not 18 '9's. The right hexadecimal value should be
0XDE0B6B3A763FFFF.

R=tkent@chromium.org, yosin@chromium.org

Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=174294

[Inactive, 2014-05-14 02:29:11]

Note that I don't fully understand the code so the change may be wrong.

I was reading through the code and noticed that the comment did not match the
value corresponding value so I decided to raise the issue by proposing a patch.

[yosin_UTC9, 2014-05-19 05:36:25]

ACK

Thanks for finding this!
Please wait for OWNERS review for committing.

https://codereview.chromium.org/281033002/diff/1/Source/platform/Decimal.cpp
File Source/platform/Decimal.cpp (right):

https://codereview.chromium.org/281033002/diff/1/Source/platform/Decimal.cpp#...
Source/platform/Decimal.cpp:49: static const uint64_t MaxCoefficient =
UINT64_C(0XDE0B6B3A763FFFF); // 999999999999999999 == 18 9's
nit: Please use small "x" instead of capital "X" for hexadecimal prefix.

[tkent, 2014-05-19 05:40:34]

lgtm

[Inactive, 2014-05-19 13:06:54]

https://codereview.chromium.org/281033002/diff/1/Source/platform/Decimal.cpp
File Source/platform/Decimal.cpp (right):

https://codereview.chromium.org/281033002/diff/1/Source/platform/Decimal.cpp#...
Source/platform/Decimal.cpp:49: static const uint64_t MaxCoefficient =
UINT64_C(0XDE0B6B3A763FFFF); // 999999999999999999 == 18 9's
On 2014/05/19 05:36:25, yosi wrote:
> nit: Please use small "x" instead of capital "X" for hexadecimal prefix.

Done.

[Inactive, 2014-05-19 13:06:58]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-05-19 13:07:12]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/281033002/20001

[commit-bot: I haz the power, 2014-05-19 14:16:58]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/8147)

[commit-bot: I haz the power, 2014-05-19 15:06:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-19 15:06:02]

Try jobs failed on following builders:
  mac_blink_rel on tryserver.blink
(http://build.chromium.org/p/tryserver.blink/builders/mac_blink_rel/builds/8153)

[Inactive, 2014-05-19 15:15:02]

The CQ bit was checked by ch.dumez@samsung.com

[commit-bot: I haz the power, 2014-05-19 15:15:09]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/281033002/20001

[commit-bot: I haz the power, 2014-05-19 15:52:13]

Change committed as 174294