Chromium Code Reviews| Index: chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java |
| diff --git a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java |
| index 5f47ee99e5cfa10a997b7ff3ac0f1cad2acc857b..cde80b0eebdbf142b56001b68a260ff99d041886 100644 |
| --- a/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java |
| +++ b/chrome/android/javatests/src/org/chromium/chrome/browser/payments/PaymentRequestMetricsTest.java |
| @@ -10,8 +10,10 @@ import android.support.test.filters.MediumTest; |
| import org.chromium.base.ThreadUtils; |
| import org.chromium.base.metrics.RecordHistogram; |
| +import org.chromium.base.test.util.CommandLineFlags; |
| import org.chromium.base.test.util.Feature; |
| import org.chromium.chrome.R; |
| +import org.chromium.chrome.browser.ChromeFeatureList; |
| import org.chromium.chrome.browser.autofill.AutofillTestHelper; |
| import org.chromium.chrome.browser.autofill.PersonalDataManager.AutofillProfile; |
| import org.chromium.chrome.browser.autofill.PersonalDataManager.CreditCard; |
| @@ -263,6 +265,27 @@ public class PaymentRequestMetricsTest extends PaymentRequestTestBase { |
| } |
| /** |
| + * Expect that the SkippedShow metric is logged when the UI directly goes |
| + * to the payment app UI during a Payment Request. |
| + */ |
| + @MediumTest |
| + @Feature({"Payments"}) |
| + @CommandLineFlags.Add({"enable-features=" + ChromeFeatureList.WEB_PAYMENTS_SINGLE_APP_UI_SKIP}) |
|
please use gerrit instead
2017/04/13 13:49:47
That's enabled by default, no need for a command l
sebsg
2017/04/13 19:45:56
Oh thanks, added the opposite test then.
|
| + public void testMetrics_SkippedShow() |
| + throws InterruptedException, ExecutionException, TimeoutException { |
| + // Complete a Payment Request with Android Pay. |
| + installPaymentApp("https://android.com/pay", HAVE_INSTRUMENTS, IMMEDIATE_RESPONSE); |
| + triggerUIAndWait("androidPayBuy", mResultReady); |
| + |
| + assertEquals(1, |
| + RecordHistogram.getHistogramValueCountForTesting( |
| + "PaymentRequest.CheckoutFunnel.SkippedShow", 1)); |
| + assertEquals(0, |
| + RecordHistogram.getHistogramValueCountForTesting( |
| + "PaymentRequest.CheckoutFunnel.Shown", 1)); |
| + } |
| + |
| + /** |
| * Expect that the "Shown" event is recorded only once. |
| */ |
| @MediumTest |