Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Unified Diff: ios/web/web_state/js/resources/core.js

Issue 2810263002: Deprecate __gCrWeb['sendFaviconsToHost'] by inlining it. (Closed)
Patch Set: Moved didFinishNavigation to legacy.js Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/web_state/js/resources/legacy.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ios/web/web_state/js/resources/core.js
diff --git a/ios/web/web_state/js/resources/core.js b/ios/web/web_state/js/resources/core.js
index 6ec37f02d7edc1bdbdd4da12b66484df983b1e42..f5ba77f2bb7ca4b2713256cb4e9f87ca265f232b 100644
--- a/ios/web/web_state/js/resources/core.js
+++ b/ios/web/web_state/js/resources/core.js
@@ -17,19 +17,6 @@ goog.require('__crWeb.message');
(function() {
__gCrWeb['core'] = {};
- /**
- * Handles document load completion tasks. Invoked from
- * [WKNavigationDelegate webView:didFinishNavigation:], when document load is
- * complete.
- */
- __gCrWeb.didFinishNavigation = function() {
- // Send the favicons to the browser.
- __gCrWeb.sendFaviconsToHost();
- // Add placeholders for plugin content.
- if (__gCrWeb.common.updatePluginPlaceholders())
- __gCrWeb.message.invokeOnHost({'command': 'addPluginPlaceholders'});
- }
-
// JavaScript errors are logged on the main application side. The handler is
// added ASAP to catch any errors in startup. Note this does not appear to
// work in iOS < 5.
@@ -40,11 +27,6 @@ goog.require('__crWeb.message');
{'command': 'window.error', 'message': event.message.toString()});
});
- __gCrWeb['sendFaviconsToHost'] = function() {
- __gCrWeb.message.invokeOnHost({'command': 'document.favicons',
- 'favicons': __gCrWeb.common.getFavicons()});
- }
-
// Flush the message queue.
if (__gCrWeb.message) {
__gCrWeb.message.invokeQueues();
« no previous file with comments | « ios/web/BUILD.gn ('k') | ios/web/web_state/js/resources/legacy.js » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698