Issue 2810223003: Attempt 2 -- Fix updating packages map on reload and add a regression test

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2810223003: Attempt 2 -- Fix updating packages map on reload and add a regression test (Closed)

Created:
3 years, 8 months ago by Cutch

Modified:
3 years, 8 months ago

Reviewers:

CC:
reviews_dartlang.org, turnidge, rmacnak, vm-dev_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Attempt 2 -- Fix updating packages map on reload and add a regression test - [x] Update the isolate's .packages path when requested. - [x] Always refresh package map when loader is initialized. - [x] Add regression test. Committed: https://github.com/dart-lang/sdk/commit/99c6a18a1bc2a4f13d8dd027a597fdca0f2d6e0c

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+40 lines, -9 lines)			Patch
M	runtime/bin/isolate_data.h	View	1 chunk	+8 lines, -0 lines	0 comments	Download
M	runtime/bin/loader.cc	View	1 chunk	+9 lines, -1 line	0 comments	Download
M	runtime/bin/vmservice/loader.dart	View	3 chunks	+9 lines, -5 lines	0 comments	Download
M	runtime/observatory/lib/src/service/object.dart	View	1 chunk	+5 lines, -1 line	0 comments	Download
A	runtime/observatory/tests/service/complex_reload/v2/.gitignore	View	1 chunk	+1 line, -0 lines	0 comments	Download
A	runtime/observatory/tests/service/complex_reload/v2/foobar_lib/foo.dart	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/complex_reload/v2/main.dart	View	1 chunk	+3 lines, -1 line	0 comments	Download
A	runtime/observatory/tests/service/complex_reload/v2/packages	View	1 chunk	+1 line, -0 lines	0 comments	Download
M	runtime/observatory/tests/service/complex_reload_test.dart	View	2 chunks	+3 lines, -1 line	0 comments	Download

Total messages: 2 (1 generated)

Cutch

3 years, 8 months ago (2017-04-12 21:02:27 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
99c6a18a1bc2a4f13d8dd027a597fdca0f2d6e0c.