Issue 2810183002: Less direct use of JavaScriptBackend in ProgramBuilder

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 2810183002: Less direct use of JavaScriptBackend in ProgramBuilder (Closed)

Created:
3 years, 8 months ago by Johnni Winther

Modified:
3 years, 8 months ago

Reviewers:
Emily Fortuna

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Less direct use of JavaScriptBackend in ProgramBuilder This is a step towards passing data object directly instead of accessing data on JavaScriptBackend. This is needed to support an element switch between resolution and codegen. R=efortuna@google.com Committed: https://github.com/dart-lang/sdk/commit/635f2fc491906ce933473ade0bc08b478ebea569

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+115 lines, -88 lines)			Patch
	M	pkg/compiler/lib/src/js_backend/backend.dart	View		1 chunk	+2 lines, -1 line	0 comments	Download
	M	pkg/compiler/lib/src/js_emitter/program_builder/program_builder.dart	View		43 chunks	+113 lines, -87 lines	0 comments	Download

Total messages: 5 (2 generated)

Johnni Winther

3 years, 8 months ago (2017-04-18 08:25:23 UTC) #5

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
635f2fc491906ce933473ade0bc08b478ebea569 (presubmit successful).