third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp - Issue 2810173003: Media Controls: move all MediaControlDivElement sub-classes to modules/.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

Issue 2810173003: Media Controls: move all MediaControlDivElement sub-classes to modules/. (Closed)

Patch Set: add class comments Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

diff --git a/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp b/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

index 48ec7094c28e43d7dee482b96a00a0a776209e43..8acf527e52421f269630c859d9a181b0fc989019 100644

--- a/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

+++ b/third_party/WebKit/Source/core/paint/MediaControlsPainter.cpp

@@ -181,7 +181,9 @@ bool MediaControlsPainter::PaintMediaOverlayPlayButton(

if (!HasSource(media_element) || !media_element->paused())

return false;

- MediaControlPanelElement* panel_element = nullptr;

+ // TODO(mlamouri): it might be possible to use the PanelLayoutOjbect() call

chrishtr 2017/04/13 22:52:04 Nit: spelling

+ // instead.

+ HTMLDivElement* panel_element = nullptr;

if (media_element->GetMediaControls())

panel_element = media_element->GetMediaControls()->PanelElement();