third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h - Issue 2810173003: Media Controls: move all MediaControlDivElement sub-classes to modules/.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: third_party/WebKit/Source/modules/media_controls/elements/MediaControlElementsHelper.h

Issue 2810173003: Media Controls: move all MediaControlDivElement sub-classes to modules/. (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
(Empty)
	1 // Copyright 2017 The Chromium Authors. All rights reserved.

	2 // Use of this source code is governed by a BSD-style license that can be

	3 // found in the LICENSE file.

	4

	5 #ifndef MediaControlElementsHelper_h

	6 #define MediaControlElementsHelper_h

	7

	8 #include "platform/wtf/Allocator.h"

	9

	10 namespace blink {

	11

	12 class Event;

	13

	14 class MediaControlElementsHelper final {
	whywhat 2017/04/12 15:36:41 Class comment? It's not clear why it's needed at a Class comment? It's not clear why it's needed at all with one static method :) mlamouri (slow - plz ping) 2017/04/13 21:59:54 Got it. Show quoted text On 2017/04/12 at 15:36:41, whywhat wrote: > Class comment? Got it. Show quoted text > It's not clear why it's needed at all with one static method :) There should be more I believe. Also, it's a method that is used by a few elements.
	15 STATIC_ONLY(MediaControlElementsHelper);

	16

	17 public:

	18 static bool IsUserInteractionEvent(Event*);

	19 };

	20

	21 } // namespace blink

	22

	23 #endif // MediaControlElementsHelper_h

OLD	NEW