content/public/browser/navigation_controller.h - Issue 2810173002: NavigationController: Fix several broken class invariants.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/public/browser/navigation_controller.h

Issue 2810173002: NavigationController: Fix several broken class invariants. (Closed)

Patch Set: Addressed comments @creis #2 Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: content/public/browser/navigation_controller.h

diff --git a/content/public/browser/navigation_controller.h b/content/public/browser/navigation_controller.h

index 4ece52b3df2a8e9ec780379c87938f386fa81ccf..ffe2eaed6a0da892bd5c104e135d2b2949709001 100644

--- a/content/public/browser/navigation_controller.h

+++ b/content/public/browser/navigation_controller.h

@@ -268,7 +268,9 @@ class NavigationController {

// committed entries.

virtual NavigationEntry* GetLastCommittedEntry() const = 0;

- // Returns the index of the last committed entry.

+ // Returns the index of the last committed entry. It will be -1 if there are

+ // no entries, or if there is a transient entry before the first entry

+ // commits.

virtual int GetLastCommittedEntryIndex() const = 0;

// Returns true if the source for the current entry can be viewed.

« no previous file with comments | « content/browser/frame_host/navigation_controller_impl_unittest.cc ('k') | no next file » | no next file with comments »