Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(197)

Side by Side Diff: content/public/browser/navigation_controller.h

Issue 2810173002: NavigationController: Fix several broken class invariants. (Closed)
Patch Set: Addressed comments @creis Created 3 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 5 #ifndef CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 6 #define CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
7 7
8 #include <stdint.h> 8 #include <stdint.h>
9 9
10 #include <map> 10 #include <map>
(...skipping 250 matching lines...) Expand 10 before | Expand all | Expand 10 after
261 261
262 // Returns the index from which we would go back/forward or reload. This is 262 // Returns the index from which we would go back/forward or reload. This is
263 // the last_committed_entry_index_ if pending_entry_index_ is -1. Otherwise, 263 // the last_committed_entry_index_ if pending_entry_index_ is -1. Otherwise,
264 // it is the pending_entry_index_. 264 // it is the pending_entry_index_.
265 virtual int GetCurrentEntryIndex() const = 0; 265 virtual int GetCurrentEntryIndex() const = 0;
266 266
267 // Returns the last committed entry, which may be null if there are no 267 // Returns the last committed entry, which may be null if there are no
268 // committed entries. 268 // committed entries.
269 virtual NavigationEntry* GetLastCommittedEntry() const = 0; 269 virtual NavigationEntry* GetLastCommittedEntry() const = 0;
270 270
271 // Returns the index of the last committed entry. 271 // Returns the index of the last committed entry. It will be -1 iff there are
272 // no entries.
Charlie Reis 2017/04/24 17:34:55 As you pointed out, this isn't true. Let's rephra
arthursonzogni 2017/04/26 12:13:48 Done.
272 virtual int GetLastCommittedEntryIndex() const = 0; 273 virtual int GetLastCommittedEntryIndex() const = 0;
273 274
274 // Returns true if the source for the current entry can be viewed. 275 // Returns true if the source for the current entry can be viewed.
275 virtual bool CanViewSource() const = 0; 276 virtual bool CanViewSource() const = 0;
276 277
277 // Navigation list ----------------------------------------------------------- 278 // Navigation list -----------------------------------------------------------
278 279
279 // Returns the number of entries in the NavigationController, excluding 280 // Returns the number of entries in the NavigationController, excluding
280 // the pending entry if there is one, but including the transient entry if 281 // the pending entry if there is one, but including the transient entry if
281 // any. 282 // any.
(...skipping 173 matching lines...) Expand 10 before | Expand all | Expand 10 after
455 456
456 private: 457 private:
457 // This interface should only be implemented inside content. 458 // This interface should only be implemented inside content.
458 friend class NavigationControllerImpl; 459 friend class NavigationControllerImpl;
459 NavigationController() {} 460 NavigationController() {}
460 }; 461 };
461 462
462 } // namespace content 463 } // namespace content
463 464
464 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_ 465 #endif // CONTENT_PUBLIC_BROWSER_NAVIGATION_CONTROLLER_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698