Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1765)

Unified Diff: milo/appengine/buildbot/console.go

Issue 2810113002: Milo buildbot builder page: Add pagnation with cursors. (Closed)
Patch Set: train Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « milo/appengine/buildbot/builder.go ('k') | milo/appengine/buildbot/datastore.go » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: milo/appengine/buildbot/console.go
diff --git a/milo/appengine/buildbot/console.go b/milo/appengine/buildbot/console.go
index b77d6a4bbe3ff42fa80c29d3a17ca980e9c2112c..a6d9a0ee5006399e25edef254a57f0e6152fba98 100644
--- a/milo/appengine/buildbot/console.go
+++ b/milo/appengine/buildbot/console.go
@@ -24,11 +24,10 @@ func getFullBuilds(c context.Context, masterName, builderName string, finished b
q = q.Eq("finished", finished)
q = q.Eq("master", masterName)
q = q.Eq("builder", builderName)
- q = q.Limit(25) // TODO(hinoka): This should be adjustable
q = q.Order("-number")
q.Finalize()
- buildbots := make([]*buildbotBuild, 0, 25)
- err := getBuildQueryBatcher(c).GetAll(c, q, &buildbots)
+ // Ignore the cursor, we don't need it.
+ buildbots, _, err := runBuildsQuery(c, q, 25)
return buildbots, err
}
« no previous file with comments | « milo/appengine/buildbot/builder.go ('k') | milo/appengine/buildbot/datastore.go » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698