Issue 2810093002: Don't duplicate switch case code if we fall through to the default case.

Issue 2810093002: Don't duplicate switch case code if we fall through to the default case. (Closed)

Created:
3 years, 8 months ago by Emily Fortuna

Modified:
3 years, 8 months ago

Reviewers:
sra1

CC:
reviews_dartlang.org

Target Ref:
refs/heads/master

Visibility:
Public.

Don't duplicate switch case code if we fall through to the default case. BUG=https://github.com/dart-lang/sdk/issues/26900 R=sra@google.com Committed: https://github.com/dart-lang/sdk/commit/81dfc04a81f58a2342d7f6cd45459f07e53f131b

Created: 3 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -1 line)			Patch
	M	pkg/compiler/lib/src/ssa/codegen.dart	View		3 chunks	+10 lines, -1 line	0 comments	Download
	M	tests/compiler/dart2js_extra/switch_test.dart	View		2 chunks	+18 lines, -0 lines	0 comments	Download

Total messages: 6 (3 generated)

Emily Fortuna

I didn't have to do anything on the kernel end because Kernel also uses this ...

3 years, 8 months ago (2017-04-11 22:30:39 UTC) #2

Emily Fortuna

3 years, 8 months ago (2017-04-11 23:28:56 UTC) #6

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
81dfc04a81f58a2342d7f6cd45459f07e53f131b (presubmit successful).