Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Unified Diff: content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java

Issue 281003002: Make ui::Snapshot asynchronous on Android, remove CompositeAndReadback. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Created 6 years, 7 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
diff --git a/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java b/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
index 709d57499b7715ae87ea59bc1c205a8305bb53a6..1c5116866d7d9ff45f35644f50392a81bf0a14f0 100644
--- a/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
+++ b/content/public/android/java/src/org/chromium/content/browser/ContentViewRenderView.java
@@ -5,8 +5,6 @@
package org.chromium.content.browser;
import android.content.Context;
-import android.graphics.Bitmap;
-import android.graphics.Canvas;
import android.graphics.Color;
import android.graphics.PixelFormat;
import android.view.Surface;
@@ -150,18 +148,7 @@ public class ContentViewRenderView extends FrameLayout {
* @return The created SurfaceView object.
*/
protected SurfaceView createSurfaceView(Context context) {
- return new SurfaceView(context) {
- @Override
- public void onDraw(Canvas canvas) {
- // We only need to draw to software canvases, which are used for taking screenshots.
- if (canvas.isHardwareAccelerated()) return;
- Bitmap bitmap = Bitmap.createBitmap(getWidth(), getHeight(),
- Bitmap.Config.ARGB_8888);
- if (nativeCompositeToBitmap(mNativeContentViewRenderView, bitmap)) {
- canvas.drawBitmap(bitmap, 0, 0, null);
- }
- }
- };
+ return new SurfaceView(context) {};
}
/**
@@ -214,7 +201,6 @@ public class ContentViewRenderView extends FrameLayout {
private native void nativeSurfaceDestroyed(long nativeContentViewRenderView);
private native void nativeSurfaceChanged(long nativeContentViewRenderView,
int format, int width, int height, Surface surface);
- private native boolean nativeCompositeToBitmap(long nativeContentViewRenderView, Bitmap bitmap);
private native void nativeSetOverlayVideoMode(long nativeContentViewRenderView,
boolean enabled);
}

Powered by Google App Engine
This is Rietveld 408576698