Chromium Code Reviews| OLD | NEW |
|---|---|
| 1 <?xml version="1.0" encoding="utf-8"?> | 1 <?xml version="1.0" encoding="utf-8"?> |
| 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. | 2 <!-- Copyright 2015 The Chromium Authors. All rights reserved. |
| 3 Use of this source code is governed by a BSD-style license that can be | 3 Use of this source code is governed by a BSD-style license that can be |
| 4 found in the LICENSE file. --> | 4 found in the LICENSE file. --> |
| 5 | 5 |
| 6 <org.chromium.chrome.browser.ntp.IncognitoNewTabPageView | 6 <org.chromium.chrome.browser.ntp.IncognitoNewTabPageView |
| 7 xmlns:android="http://schemas.android.com/apk/res/android" | 7 xmlns:android="http://schemas.android.com/apk/res/android" |
| 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" | 8 xmlns:chrome="http://schemas.android.com/apk/res-auto" |
| 9 android:id="@+id/ntp_content" | 9 android:id="@+id/ntp_content" |
| 10 android:layout_width="match_parent" | 10 android:layout_width="match_parent" |
| (...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after Loading... | |
| 44 <TextView | 44 <TextView |
| 45 android:layout_width="wrap_content" | 45 android:layout_width="wrap_content" |
| 46 android:layout_height="wrap_content" | 46 android:layout_height="wrap_content" |
| 47 android:fontFamily="sans-serif-light" | 47 android:fontFamily="sans-serif-light" |
| 48 android:text="@string/new_tab_incognito_header" | 48 android:text="@string/new_tab_incognito_header" |
| 49 android:textColor="#d2d2d2" | 49 android:textColor="#d2d2d2" |
| 50 android:textSize="24sp" /> | 50 android:textSize="24sp" /> |
| 51 | 51 |
| 52 <TextView | 52 <TextView |
| 53 android:id="@+id/new_tab_incognito_message" | 53 android:id="@+id/new_tab_incognito_message" |
| 54 style="@style/IncognitoNewTabMessage" | |
| 54 android:layout_width="wrap_content" | 55 android:layout_width="wrap_content" |
| 55 android:layout_height="wrap_content" | 56 android:layout_height="wrap_content" |
| 56 android:layout_marginTop="32dp" | 57 android:layout_marginTop="32dp" |
| 57 android:layout_marginBottom="10dp" | 58 android:layout_marginBottom="10dp" |
| 58 android:maxWidth="660dp" | |
| 59 android:singleLine="false" | |
| 60 android:text="@null" | 59 android:text="@null" |
| 61 android:textColor="#bdbdbd" | 60 android:textColor="#bdbdbd" /> |
| 62 android:textSize="14sp" | |
| 63 android:lineSpacingMultiplier="1.2" /> | |
| 64 | 61 |
| 65 <TextView | 62 <TextView |
| 66 android:id="@+id/learn_more" | 63 android:id="@+id/learn_more" |
| 64 style="@style/IncognitoNewTabLearnMoreLink" | |
| 67 android:layout_width="wrap_content" | 65 android:layout_width="wrap_content" |
| 68 android:layout_height="wrap_content" | 66 android:layout_height="wrap_content" |
| 69 android:background="?attr/listChoiceBackgroundIndicator" | |
| 70 android:clickable="true" | |
| 71 android:focusable="true" | |
| 72 android:fontFamily="sans-serif-medium" | 67 android:fontFamily="sans-serif-medium" |
| 73 android:padding="16dp" | |
| 74 android:text="@string/learn_more" | 68 android:text="@string/learn_more" |
| 75 android:textAllCaps="true" | 69 android:textColor="#03a9f4" /> |
|
dgn
2017/04/15 12:37:04
nit: you're setting the background in the style, w
Theresa
2017/04/17 15:38:08
R.color.incognito_primary_color is used for the in
| |
| 76 android:textColor="#03a9f4" | |
| 77 android:textSize="14sp" /> | |
| 78 | 70 |
| 79 </LinearLayout> | 71 </LinearLayout> |
| 80 | 72 |
| 81 </org.chromium.chrome.browser.ntp.NewTabPageScrollView> | 73 </org.chromium.chrome.browser.ntp.NewTabPageScrollView> |
| 82 | 74 |
| 83 </org.chromium.chrome.browser.ntp.IncognitoNewTabPageView> | 75 </org.chromium.chrome.browser.ntp.IncognitoNewTabPageView> |
| OLD | NEW |