runtime/vm/isolate.cc - Issue 2809863002: Remove background finalization.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: runtime/vm/isolate.cc

Issue 2809863002: Remove background finalization. (Closed)

Patch Set: . Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: runtime/vm/isolate.cc

diff --git a/runtime/vm/isolate.cc b/runtime/vm/isolate.cc

index c7749e2db0cabb47618aa3bf3e90a13655039b5c..500afc84f0191ac7d368cec97ad1cc70599d4d02 100644

--- a/runtime/vm/isolate.cc

+++ b/runtime/vm/isolate.cc

@@ -1605,8 +1605,7 @@ class FinalizeWeakPersistentHandlesVisitor : public HandleVisitor {

void VisitHandle(uword addr) {

FinalizablePersistentHandle* handle =

reinterpret_cast<FinalizablePersistentHandle*>(addr);

- FinalizationQueue* queue = NULL; // Finalize in the foreground.

- handle->UpdateUnreachable(thread()->isolate(), queue);

+ handle->UpdateUnreachable(thread()->isolate());

}

private:

« no previous file with comments | « runtime/vm/gc_marker.cc ('k') | runtime/vm/scavenger.cc » ('j') | no next file with comments »