Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(184)

Unified Diff: third_party/WebKit/Source/modules/geolocation/PositionCallback.idl

Issue 2809843002: Geolocation: rename Geoposition to Position to follow Spec (Closed)
Patch Set: foolip@ comments Created 3 years, 8 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/geolocation/PositionCallback.idl
diff --git a/third_party/WebKit/Source/modules/geolocation/PositionCallback.idl b/third_party/WebKit/Source/modules/geolocation/PositionCallback.idl
index 64f380344329dd9574baaeb1cf62ea8519cc3f48..3b7bf48226f7350bd5253a4cd1df2ee176de7c8b 100644
--- a/third_party/WebKit/Source/modules/geolocation/PositionCallback.idl
+++ b/third_party/WebKit/Source/modules/geolocation/PositionCallback.idl
@@ -23,6 +23,11 @@
* DAMAGE.
*/
+// https://www.w3.org/TR/geolocation-API/#position-callback
+
+// TODO(mcasas, foolip): PositionCallback should be a callback function, not an
+// interface, see https://crbug.com/569301
foolip 2017/04/11 16:35:37 s/an interface/a callback interface/
+
callback interface PositionCallback {
- void handleEvent(Geoposition position);
+ void handleEvent(Position position);
};

Powered by Google App Engine
This is Rietveld 408576698