third_party/WebKit/LayoutTests/geolocation-api/position-string.html - Issue 2809843002: Geolocation: rename Geoposition to Position to follow Spec

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/LayoutTests/geolocation-api/position-string.html

Issue 2809843002: Geolocation: rename Geoposition to Position to follow Spec (Closed)

Patch Set: Created 3 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/geolocation/BUILD.gn » ('j') | third_party/WebKit/Source/modules/geolocation/PositionCallback.idl » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/LayoutTests/geolocation-api/position-string.html

diff --git a/third_party/WebKit/LayoutTests/geolocation-api/position-string.html b/third_party/WebKit/LayoutTests/geolocation-api/position-string.html

index d5298dfc08737f554cb62c9699b0f89d23241089..665d4f1a1b3636bb6ddc055faa896b2437f08fff 100644

--- a/third_party/WebKit/LayoutTests/geolocation-api/position-string.html

+++ b/third_party/WebKit/LayoutTests/geolocation-api/position-string.html

@@ -27,7 +27,7 @@ geolocationServiceMock.then(mock => {

shouldBe('position.coords.latitude', 'mockLatitude');

shouldBe('position.coords.longitude', 'mockLongitude');

shouldBe('position.coords.accuracy', 'mockAccuracy');

- shouldBe('position.toString()', '"[object Geoposition]"');

+ shouldBe('position.toString()', '"[object Position]"');

foolip 2017/04/11 14:09:53 "This change does not surface to the Web platform

mcasas 2017/04/11 16:22:16 Done updating CL description.

shouldBe('position.coords.toString()', '"[object Coordinates]"');

finishJSTest();

}, function(e) {

« no previous file with comments | « no previous file | third_party/WebKit/Source/modules/geolocation/BUILD.gn » ('j') | third_party/WebKit/Source/modules/geolocation/PositionCallback.idl » ('J')