Implement sync in the NonBlockingTypeProcessor

sync/engine/non_blocking_sync_common.h

+// Copyright 2014 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef SYNC_ENGINE_NON_BLOCKING_SYNC_COMMON_H_
+#define SYNC_ENGINE_NON_BLOCKING_SYNC_COMMON_H_
+
+#include <string>
+#include <vector>
+
+#include "base/time/time.h"
+#include "sync/base/sync_export.h"
+#include "sync/protocol/sync.pb.h"
+
+namespace syncer {
+
+struct SYNC_EXPORT_PRIVATE DataTypeState {
+  DataTypeState();
+  ~DataTypeState();
+
+  sync_pb::DataTypeProgressMarker progress_marker;

[Nicolas Zea, 2014/05/20 21:51:08]

I'd prefer to have comments for all these fields.

[rlarocque, 2014/05/20 22:29:21]

I've added a bunch around DataTypeState.  I think those definitions are likely
to be stable.

I'm a bit more reluctant to add lots of comments around the others.  I see them
as being like SyncBackendHost's DoInitializeOptions: function parameters that
have grown so numerous that they had to be refactored into a struct.

They should be well documented in the places where they're used.  It's hard to
document them here, since they don't actually do anything here.  Also, the
documentation near where they're used will be more likely to be updated and
maintained if the meaning of these fields changes.

+  sync_pb::DataTypeContext type_context;
+  std::string parent_id;
+  int64 next_id;
+};
+
+struct SYNC_EXPORT_PRIVATE CommitRequestData {
+  CommitRequestData();
+  ~CommitRequestData();
+
+  std::string id;
+  std::string client_tag_hash;
+  int64 sequence_number;
+  int64 base_version;
+  base::Time ctime;
+  base::Time mtime;
+  std::string non_unique_name;
+  bool deleted;
+  sync_pb::EntitySpecifics specifics;
+};
+
+struct SYNC_EXPORT_PRIVATE CommitResponseData {
+  CommitResponseData();
+  ~CommitResponseData();
+
+  std::string id;
+  std::string client_tag_hash;
+  int64 sequence_number;
+  int64 response_version;
+};
+
+struct SYNC_EXPORT_PRIVATE UpdateResponseData {
+  UpdateResponseData();
+  ~UpdateResponseData();
+
+  std::string id;
+  std::string client_tag_hash;
+  int64 response_version;
+  base::Time ctime;
+  base::Time mtime;
+  std::string non_unique_name;
+  bool deleted;
+  sync_pb::EntitySpecifics specifics;
+};
+
+typedef std::vector<CommitRequestData> CommitRequestDataList;
+typedef std::vector<CommitResponseData> CommitResponseDataList;
+typedef std::vector<UpdateResponseData> UpdateResponseDataList;
+
+}  // namespace syncer
+
+#endif  // SYNC_ENGINE_NON_BLOCKING_SYNC_COMMON_H_