Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(475)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2809793004: CLI support for `enableAssertInitializer`s. (Closed)

Created:
3 years, 8 months ago by pquitslund
Modified:
3 years, 8 months ago
Reviewers:
Brian Wilkerson
CC:
reviews_dartlang.org, tvolkert
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Total comments: 1

Patch Set 2 : options fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+35 lines, -0 lines) Patch
M pkg/analyzer_cli/lib/src/driver.dart View 2 chunks +5 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/lib/src/options.dart View 3 chunks +10 lines, -0 lines 0 comments Download
A pkg/analyzer_cli/test/data/file_with_assert_initializers.dart View 1 chunk +7 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/driver_test.dart View 1 chunk +6 lines, -0 lines 0 comments Download
M pkg/analyzer_cli/test/options_test.dart View 2 chunks +7 lines, -0 lines 0 comments Download

Messages

Total messages: 6 (2 generated)
pquitslund
Note that I needed to --bypass-hooks since `dartfmt` doesn't support enableAssertInitializer parsing.
3 years, 8 months ago (2017-04-12 16:33:57 UTC) #2
Brian Wilkerson
Other than the one concern, lgtm. https://codereview.chromium.org/2809793004/diff/1/pkg/analyzer_cli/.analysis_options File pkg/analyzer_cli/.analysis_options (right): https://codereview.chromium.org/2809793004/diff/1/pkg/analyzer_cli/.analysis_options#newcode6 pkg/analyzer_cli/.analysis_options:6: enableAssertInitializer: true I ...
3 years, 8 months ago (2017-04-12 16:41:35 UTC) #3
pquitslund
On 2017/04/12 16:41:35, Brian Wilkerson wrote: > Other than the one concern, lgtm. > > ...
3 years, 8 months ago (2017-04-12 17:35:54 UTC) #4
pquitslund
3 years, 8 months ago (2017-04-12 17:38:38 UTC) #6
Message was sent while issue was closed. 
Committed patchset #2 (id:20001) manually as
1d4d0d769ff2c8c83569a076f067a930e3cb6462.

Powered by Google App Engine
This is Rietveld 408576698