Build Chrome Remote Desktop for iOS in Chromium trybots.

remoting/client/ios/host_preferences.mm

 // Copyright 2017 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #if !defined(__has_feature) || !__has_feature(objc_arc)
 #error "This file requires ARC support."
 #endif
 
 #import "remoting/client/ios/host_preferences.h"
 
@@ skipping 26 matching lines @@
 
 - (void)saveToKeychain {
   NSMutableDictionary* hosts = [HostPreferences loadHosts];
   [hosts setObject:self forKey:_hostId];
 
   NSData* writeData = [NSKeyedArchiver archivedDataWithRootObject:hosts];
 
   NSError* keychainError =
       remoting::ios::WriteHostPreferencesToKeychain(writeData);
 
-  DLOG_IF(ERROR, !keychainError) << "Could not write to keychain.";
+  if (!keychainError) {

[sdefresne, 2017/04/12 15:27:52]

This is https://codereview.chromium.org/2817513004/, right? Maybe rebase your CL
on top of it so that this is marked as a dependent CL and does not show in this
one :-)

[nicholss, 2017/04/12 15:35:32]

I am working on removing this file from this cl :)

+    LOG(ERROR) << "Could not write to keychain.";
+  }
 }
 
 + (HostPreferences*)hostForId:(NSString*)hostId {
   NSMutableDictionary* hosts = [HostPreferences loadHosts];
   HostPreferences* host = hosts[hostId];
   if (!host) {
     host = [[HostPreferences alloc] init];
     host.hostId = hostId;
     host.pairId = @"";
     host.pairSecret = @"";
@@ skipping 25 matching lines @@
   return self;
 }
 
 - (void)encodeWithCoder:(NSCoder*)coder {
   [coder encodeObject:_hostId forKey:kHostPreferencesHostIdKey];
   [coder encodeObject:_pairId forKey:kHostPreferencesPairIdKey];
   [coder encodeObject:_pairSecret forKey:kHostPreferencesPairSecretKey];
 }
 
 @end