Build Chrome Remote Desktop for iOS in Chromium trybots.

media/media_options.gni

 # Copyright 2014 The Chromium Authors. All rights reserved.
 # Use of this source code is governed by a BSD-style license that can be
 # found in the LICENSE file.
 
 import("//build/config/chromecast_build.gni")
 import("//build/config/features.gni")
 import("//testing/libfuzzer/fuzzer_test.gni")
 
 declare_args() {
   # Allows distributions to link pulseaudio directly (DT_NEEDED) instead of
   # using dlopen. This helps with automated detection of ABI mismatches and
   # prevents silent errors.
   link_pulseaudio = false
 
   # Enable usage of FFmpeg within the media library. Used for most software
   # based decoding, demuxing, and sometimes optimized FFTs. If disabled,
   # implementors must provide their own demuxers and decoders.
   media_use_ffmpeg = true
 
   # Enable usage of libvpx within the media library. Used for software based
   # decoding of VP9 and VP8A type content.
   media_use_libvpx = true
 
   # iOS doesn't use ffmpeg, libvpx.
   if (is_ios) {

[sdefresne, 2017/04/12 15:27:52]

I think this condition will always be false. I would move this outside of the
declare_args:

declare_args() {
  ...
  # Enable usage of FFmpeg within the media library. Used for most software
  # based decoding, demuxing, and sometimes optimized FFTs. If disabled,
  # implementors must provide their own demuxers and decoders.
  media_use_ffmpeg = true

  # Enable usage of libvpx within the media library. Used for software based
  # decoding of VP9 and VP8A type content.
  media_use_libvpx = true
  ...
}

# iOS doesn't use ffmpeg, libvpx.
if (is_ios) {
  media_use_ffmpeg = false
  media_use_libvpx = false
}

If done, this should probably be done as a followup CL.

[nicholss, 2017/04/12 15:35:32]

This is very interesting. I wonder how many places this mistake is made in
chromium.

     media_use_ffmpeg = false
     media_use_libvpx = false
   }
 
   # Override to dynamically link the cras (ChromeOS audio) library.
   use_cras = false
 
   # Use low-memory buffers on non-Android builds of Chromecast.
   use_low_memory_buffer = is_chromecast && !is_android
 
@@ skipping 11 matching lines @@
 
   # Enable HEVC/H265 demuxing. Actual decoding must be provided by the
   # platform. Enable by default for Chromecast.
   enable_hevc_demuxing = proprietary_codecs && is_chromecast
 
   # Enable Dolby Vision demuxing. Enable by default for Chromecast. Actual
   # decoding must be provided by the platform. Note some Dolby Vision profiles
   # which are encoded using HEVC require |enable_hevc_demuxing| to be enabled.
   enable_dolby_vision_demuxing = proprietary_codecs && is_chromecast
 
-  enable_webrtc = !is_ios && !is_cast_audio_only
+  enable_webrtc = !is_cast_audio_only
 
   # Enable HLS with SAMPLE-AES decryption.
   # Enabled by default on the cast desktop implementation to allow unit tests of
   # MP2TS parsing support.
   enable_hls_sample_aes = proprietary_codecs && is_cast_desktop_build
 
   # If true, use cast CMA backend instead of default chromium media pipeline.
   is_cast_using_cma_backend = is_cast_audio_only || !is_android
 }
 
@@ skipping 103 matching lines @@
     }
   }
 }
 
 declare_args() {
   # This switch defines whether the Media Remoting implementation will be built.
   # When enabled, media is allowed to be renderer and played back on remote
   # devices when the tab is being casted and other conditions are met.
   enable_media_remoting = !is_chromecast && !is_ios && !is_android
 }