[LargeIconService] Report size of favicon for fallback style to UMA

components/favicon/core/large_icon_service.cc

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "components/favicon/core/large_icon_service.h"
 
 #include <memory>
 
 #include "base/bind.h"
 #include "base/location.h"
@@ skipping 99 matching lines @@
         *bitmap = image.AsBitmap();
       }
       return;
     }
   }
 
   if (!fallback_icon_style)
     return;
 
   *fallback_icon_style = favicon_base::FallbackIconStyle();
+  int fallback_icon_size = 0;
   if (db_result.is_valid()) {
     favicon_base::SetDominantColorAsBackground(db_result.bitmap_data,
                                                fallback_icon_style);
+    fallback_icon_size = db_result.pixel_size.width();
   }
+  UMA_HISTOGRAM_COUNTS_100("Favicons.LargeIconService.FallbackSize",
+                           fallback_icon_size);

[Ilya Sherman, 2017/04/11 21:36:09]

Perhaps UMA_HISTOGRAM_SPARSE_SLOWLY, with some custom sanity-checks on the
logged value, would be more appropriate?

[jkrcal, 2017/04/12 05:40:51]

Done. 
No sanity checks are needed as this must be non-negative and relatively small
number (<100) by definition. If not, there are some bugs that we would like to
see :)

[Ilya Sherman, 2017/04/12 20:45:33]

Okay.  Could you please add a DCHECK at least?  =)

[jkrcal, 2017/04/13 07:16:05]

Done (I check only the lower limit, the upper limit depends on what the client
passes as |min_source_size| and I do not want to restrict something that the API
allows).

 }
 
 // Processes the bitmap data returned from the FaviconService as part of a
 // LargeIconService request.
 class LargeIconWorker : public base::RefCountedThreadSafe<LargeIconWorker> {
  public:
   // Exactly one of the callbacks is expected to be non-null.
   LargeIconWorker(int min_source_size_in_pixel,
                   int desired_size_in_pixel,
                   favicon_base::LargeIconCallback raw_bitmap_callback,
@@ skipping 210 matching lines @@
   // TODO(beaudoin): For now this is just a wrapper around
   //   GetLargestRawFaviconForPageURL. Add the logic required to select the best
   //   possible large icon. Also add logic to fetch-on-demand when the URL of
   //   a large icon is known but its bitmap is not available.
   return favicon_service_->GetLargestRawFaviconForPageURL(
       page_url, large_icon_types_, min_source_size_in_pixel,
       base::Bind(&LargeIconWorker::OnIconLookupComplete, worker), tracker);
 }
 
 }  // namespace favicon