Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(177)

Issue 2809773005: Fix parsing of generic function types as return types (Closed)

Created:
3 years, 8 months ago by Brian Wilkerson
Modified:
3 years, 8 months ago
Reviewers:
scheglov
CC:
reviews_dartlang.org
Target Ref:
refs/heads/master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : re-upload #

Patch Set 3 : remove test #

Unified diffs Side-by-side diffs Delta from patch set Stats (+153 lines, -10 lines) Patch
M pkg/analyzer/lib/src/generated/parser.dart View 7 chunks +87 lines, -10 lines 0 comments Download
M pkg/analyzer/test/generated/parser_test.dart View 1 2 3 chunks +66 lines, -0 lines 0 comments Download

Messages

Total messages: 5 (2 generated)
Brian Wilkerson
Not sure this is all the parsing problems, but it should take care of a ...
3 years, 8 months ago (2017-04-12 02:02:13 UTC) #2
scheglov
LGTM
3 years, 8 months ago (2017-04-12 06:18:03 UTC) #3
Brian Wilkerson
3 years, 8 months ago (2017-04-12 14:27:45 UTC) #5
Message was sent while issue was closed.
Committed patchset #3 (id:40001) manually as
492eab84ece070ff262b958d0786fa42db9645df (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698